Re: [Gnash-commit] /srv/bzr/gnash/trunk r10551: Implement _quality and _highquality for TextField and Button.

[Bastiaan Jacques]

Hi,

I think I spotted a bug in this commit. It replaces

#define TWIPS_TO_SHIFTED_PIXELS(x) (x*0.05f + 0.5f)

with twipsToPixels(x) + 0.05. I presume this is a typo. Do you concur?

Bastiaan

On Thu, 22 Jan 2009, Benjamin Wolsey wrote:

> ------------------------------------------------------------
> revno: 10551
> committer: Benjamin Wolsey <address@hidden>
> branch nick: trunk
> timestamp: Thu 2009-01-22 16:28:34 +0100
> message:
>  Implement _quality and _highquality for TextField and Button.
>
>  Clean up AGG renderer and rendering interface; agg now passes all
>  the DrawingApi tests.
>
>  Revert cxform commit 10545.1.13, which broke things.
> modified:
>  backend/render_handler.h
>  backend/render_handler_agg.cpp
>  backend/render_handler_cairo.cpp
>  backend/render_handler_ogl.cpp
>  libcore/Button.cpp
>  libcore/TextField.cpp
>  libcore/asobj/TextFormat_as.cpp
>  libcore/cxform.cpp
>  libcore/parser/shape_character_def.cpp
>  libcore/parser/shape_character_def.h
>  libcore/swf/TextRecord.cpp
>  testsuite/actionscript.all/TextField.as
>  testsuite/misc-ming.all/DrawingApiTestRunner.cpp
>    ------------------------------------------------------------
>    revno: 10550.1.1
>    committer: Benjamin Wolsey <address@hidden>
>    branch nick: work
>    timestamp: Thu 2009-01-22 08:08:28 +0100
>    message:
>      Minor cleanups.
>    modified:
>      backend/render_handler_agg.cpp
>    ------------------------------------------------------------
>    revno: 10550.1.2
>    committer: Benjamin Wolsey <address@hidden>
>    branch nick: work
>    timestamp: Thu 2009-01-22 15:35:44 +0100
>    message:
>      Implement _quality and _highquality for TextField and Button.
>      Passes in actionscript.all. Expect one failure, as it was only passing
>      because unimplemented; now it fails for the same reason as other
>      prototype (non-)properties.
>    modified:
>      libcore/Button.cpp
>      libcore/TextField.cpp
>      testsuite/actionscript.all/TextField.as
>    ------------------------------------------------------------
>    revno: 10550.1.3
>    committer: Benjamin Wolsey <address@hidden>
>    branch nick: work
>    timestamp: Thu 2009-01-22 15:36:37 +0100
>    message:
>      Drop display() function with custom matrix and styles from 
> shape_character_def.
>
>      Drop unused dummy line and fill styles from TextRecord.
>    modified:
>      libcore/parser/shape_character_def.cpp
>      libcore/parser/shape_character_def.h
>      libcore/swf/TextRecord.cpp
>    ------------------------------------------------------------
>    revno: 10550.1.4
>    committer: Benjamin Wolsey <address@hidden>
>    branch nick: work
>    timestamp: Thu 2009-01-22 15:36:58 +0100
>    message:
>      Correct unimpl messages.
>    modified:
>      libcore/asobj/TextFormat_as.cpp
>    ------------------------------------------------------------
>    revno: 10550.1.5
>    committer: Benjamin Wolsey <address@hidden>
>    branch nick: work
>    timestamp: Thu 2009-01-22 15:37:28 +0100
>    message:
>      Remove styles from draw_shape_character() in renderer interface, as these
>      should be obtained from the character definition.
>
>      Other AGG cleanups.
>    modified:
>      backend/render_handler.h
>      backend/render_handler_agg.cpp
>      backend/render_handler_cairo.cpp
>      backend/render_handler_ogl.cpp
>      testsuite/misc-ming.all/DrawingApiTestRunner.cpp
>    ------------------------------------------------------------
>    revno: 10550.1.6
>    committer: Benjamin Wolsey <address@hidden>
>    branch nick: work
>    timestamp: Thu 2009-01-22 15:52:53 +0100
>    message:
>      Revert cxform changes.
>    modified:
>      libcore/cxform.cpp