[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] /srv/bzr/gnash/trunk r11776: we need to make the stri
|
From: |
Rob Savoye |
|
Subject: |
Re: [Gnash-commit] /srv/bzr/gnash/trunk r11776: we need to make the string one character larger to keep valgrind happy. |
|
Date: |
Wed, 20 Jan 2010 09:05:38 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0b1pre Thunderbird/3.0 |
On 01/20/10 08:58, strk wrote:
> If valgrind was not happy above it means that the string in your buffer
> wasn't NULL-terminated. By passing a second argument to std::string
> constructor
> you instruct it to stop after reading those many bytes, no matter
> null-termination.
It is not a NULL terminated string, it's raw data that just happens to
contain ASCII text, so the fix is correct, as constructing a string was
trying to read the non-existent NULL byte.
- rob -