Re: [Gnash-commit] /srv/bzr/gnash/trunk r12341: Refactored input device support for the framebuffer GUI.

[Rob Savoye]

On 07/30/10 01:24, Benjamin Wolsey wrote:
> When I try to build Gnash with all GUIs now I get the following errors
> and warnings. This was after autogen.sh and configure:

  You are missing tslib, which shouldn't matter. That does sound like a bug.

> It seems TouchDevice and InputDevice are built not only for FB, but also
> for all the other GUIs, which seems wrong (not to mention adding to the
> build time!).

  I have had some thoughts about using both the Touchscreen with GTK on
X11, so currently they all get built in gui if you select the FB GUI.
I'm also not sure if if would be better to use the input event devices
(/dev/input/*) with GTK than using the glib functions for this.

> If the FB GUI is disabled, the other GUIs build fine without the extra
> code building.

  Which is the important part. :-) Most people don't build the FB GUI.

> There are also many warnings that point to bugs in the code, and fixing
> the warnings would be easier than waiting for bug reports!

  Most of "the code" already existed in a poor state, so many of those
warnings are inherited. Most of what I've done is just rearrange which
file code lives in. I assume you never built the fb gui, so didn't
notice. I plan to eliminate all of those on the next pass through this
code. Much of this was more C than C++, I've been fixing that up too as
I go along. This is the last thing I plan to finish before the code freeze.

        - rob -