Re: [Gnash-commit] [SCM] Gnash branch, master, updated. 29788d8c2d19aef2f6aed70f633d706cd8cc7b36

[strk]

On Thu, Dec 02, 2010 at 08:43:05PM +0100, Benjamin Wolsey wrote:
> Am Donnerstag, den 02.12.2010, 12:32 -0700 schrieb Rob Savoye:
> > On 12/02/10 12:25, Benjamin Wolsey wrote:
> > > 
> > >> +#if (PNG_LIBPNG_VER_RELEASE < 9)
> > >> +        png_set_gray_1_2_4_to_8(_pngPtr);
> > >> +#else
> > >> +        png_set_expand_gray_1_2_4_to_8(_pngPtr);
> > >> +#endif
> > > 
> > > Using PNG_LIBPNG_VER_RELEASE isn't very sensible, because both 1.0.9 and
> > > 1.4.4 (the most recent version) fail to use the correct functions.
> > 
> >   It was working for me with 1.4.4 too, but any simple constant to
> > determine the version is all this needs. The distro I'm dealing with
> > only ships libpng1.2, and upgrading broke a bunch of the other packages.
> > The whole distro isn't very up to date.
> 
> It's not logical to expect it to work with 1.4.4 because
> PNG_LIBPNG_VER_RELEASE is 4 in that case. It certainly prevents
> compilation for my setup with png 1.4.4.
> 
> It seems to me that the newer function is available when both the
> following conditions are met:
> 
> a) major version is 2 or greater (there's no such version currently).
> b) major version is 1 and minor version is 4 or greater.

What about checking for the actual function with AC_CHECK_FUNC (or
whatever it is) ?

--strk;

  ()   Free GIS & Flash consultant/developer
  /\   http://strk.keybit.net/services.html