[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] [SCM] Gnash branch, master, updated. e6898df7bd6e990f
From: |
Benjamin Wolsey |
Subject: |
Re: [Gnash-commit] [SCM] Gnash branch, master, updated. e6898df7bd6e990f8cba8d7f899d4af50c78ebab |
Date: |
Sun, 12 Dec 2010 15:51:24 +0100 |
> This change modifies the semantic too. Was it tested ?
> (just confused by the "Fix warning" commit log ...)
A previous commit changed the type of ratio from signed to unsigned,
because the DisplayObject ratio is an unsigned value between 0 and
65535.
This caused the compiler to emit a warning for a case that hadn't
actually changed, only it's now obvious that ratio can never be less
than 0: the old test was completely useless. Moreover, it didn't do what
the comment said ("Don't add if the DisplayObject has no ratio value").
I changed the code to do what the comment said, which would have made a
better commit message.
It's only for the SWF property tree, so it neither has any effect on
Gnash core, nor on the testsuite.
bwy
--
--
Use Gnash, the GNU Flash Player!
http://www.gnu.org/software/gnash/
Benjamin Wolsey, Software Developer - http://benjaminwolsey.de
C++ and Open-Source Flash blog - http://www.benjaminwolsey.de/bwysblog
xmpp:address@hidden
http://identi.ca/bwy
signature.asc
Description: This is a digitally signed message part