|
From: | Gabriele Giacone |
Subject: | Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_start-66-g17d5a9b |
Date: | Tue, 15 Feb 2011 14:21:32 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100918 Iceowl/1.0b2 Icedove/3.1.4 |
On 02/15/2011 08:33 AM, strk wrote: >> else >> - if test -d ${KDE4_PREFIX}/lib64; then >> + if test -d ${KDE4_PREFIX}/lib64 -a ! -h ${KDE4_PREFIX}/lib64; then >> KDE4_PLUGINDIR="${KDE4_PREFIX}/lib64/kde4" >> else >> KDE4_PLUGINDIR="${KDE4_PREFIX}/lib/kde4" >> fi >> fi > > This is suspicious. > You do strong checking against lib64/kde4 > and no checking at all for lib/kde4 ... > > What if lib64/kde4 is the only existing one, symlinking who knows where ? On Debian *-amd64 archs, /lib64 and /usr/lib64 are just symlinks to /lib and /usr/lib which are the same real path on all archs. 0aecfe8e43 broke debian packaging on *amd64 by considering /usr/lib64 as good. This fix makes build ignore such dir if it's a link. -- Gabriele
[Prev in Thread] | Current Thread | [Next in Thread] |