Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_start-286-g68c57a8

[Bastiaan Jacques]

On Thu, 17 Mar 2011, Markus Gothe wrote:

> -class WAVWriter {
> +class DSOEXPORT WAVWriter {

I don't see this class being used outside of its DSO. Why did you add
this particular DSOEXPORT?

I think the indentation in this hunk is not per Gnash code style:

> -/// Manage a list of URL access configuration
> -// stuff for an URLAccessManager
> -namespace URLAccessManager {
> -
> -/// Return true if access to given url is allowed, false otherwise.
> -//
> -/// Will use rc file for whitelist/blacklist and localSandbox.
> -///
> -/// @param url
> -///   The url to check
> -///
> -/// @param baseurl
> -///   The originating url, only used for local urls and only
> -///   for protocol checking (ie: a non-local originating url
> -///   will not be allowed to load a local url)
> -///
> -bool allow(const URL& url, const URL& baseurl);
> -
> -//bool allowHost(const std::string& str);
> -
> -// Used by XMLSocket::connect (and others?)
> -bool allowXMLSocket(const std::string& str, short port);
> -
> -} // AccessManager
> +       /// Manage a list of URL access configuration
> +       // stuff for an URLAccessManager
> +       namespace URLAccessManager {
> +
> +       /// Return true if access to given url is allowed, false otherwise.
> +       //
> +       /// Will use rc file for whitelist/blacklist and localSandbox.
> +       ///
> +       /// @param url
> +       ///   The url to check
> +       ///
> +       /// @param baseurl
> +       ///   The originating url, only used for local urls and only
> +       ///   for protocol checking (ie: a non-local originating url
> +       ///   will not be allowed to load a local url)
> +       ///
> +       bool allow(const URL& url, const URL& baseurl);
> +
> +       //bool allowHost(const std::string& str);
> +
> +       // Used by XMLSocket::connect (and others?)
> +       DSOEXPORT bool allowXMLSocket(const std::string& str, short port);
> +
> +       } // AccessManager
>
> } // namespace gnash

Bastiaan