[Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_start-294-g9d04300

[Sandro Santilli]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  9d04300cadb7c3d2b0b53d355e18052f290e9ac5 (commit)
      from  2fd706fd5aa815013b7589958cd1716e0395b832 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=9d04300cadb7c3d2b0b53d355e18052f290e9ac5


commit 9d04300cadb7c3d2b0b53d355e18052f290e9ac5
Author: Sandro Santilli <address@hidden>
Date:   Fri Mar 18 18:11:33 2011 +0100

    Revert the change about missing bitmaps as it broke another test. Leave 
comments about the case right in the code.

diff --git a/librender/agg/Renderer_agg_style.h 
b/librender/agg/Renderer_agg_style.h
index 159caf9..571f9d0 100644
--- a/librender/agg/Renderer_agg_style.h
+++ b/librender/agg/Renderer_agg_style.h
@@ -20,7 +20,8 @@
 #define BACKEND_RENDER_HANDLER_AGG_STYLE_H
 
 // TODO: Instead of re-creating AGG fill styles again and again, they should
-// be cached somewhere.
+// be cached somewhere. NOTE that bitmap styles referencing bitmaps would need
+// to re-check the bitmap definitions as parsing goes on.
 
 #include <vector>
 #include <boost/ptr_container/ptr_vector.hpp>
@@ -460,7 +461,11 @@ public:
         const SWFCxForm& cx, bool repeat, bool smooth) {
 
         if (!bi) {
-            add_color(agg::rgba8_pre(255,0,0,255));
+            // For misc-swfmill.all/missing_bitmap.swf should be 255,0,0,255
+            // For misc-ming.all/BeginBitmapFill.swf should be 0,0,0,0
+            // See https://savannah.gnu.org/bugs/index.php?32833
+            //add_color(agg::rgba8_pre(255,0,0,255));
+            add_color(agg::rgba8_pre(0,0,0,0));
             return;
         }
 
diff --git a/testsuite/misc-swfmill.all/missing_bitmapTestRunner.cpp 
b/testsuite/misc-swfmill.all/missing_bitmapTestRunner.cpp
index d60cdc2..c448fe6 100644
--- a/testsuite/misc-swfmill.all/missing_bitmapTestRunner.cpp
+++ b/testsuite/misc-swfmill.all/missing_bitmapTestRunner.cpp
@@ -61,7 +61,9 @@ main(int /*argc*/, char** /*argv*/)
 
        int tol = 15;
 
-       check_pixel(100, 100, 20, red, tol);
+
+    // See https://savannah.gnu.org/bugs/index.php?32833
+       xcheck_pixel(100, 100, 20, red, tol);
        check_pixel(300, 100, 20, white, tol);
        check_pixel(100, 300, 20, white, tol);
 

-----------------------------------------------------------------------

Summary of changes:
 librender/agg/Renderer_agg_style.h                 |    9 +++++++--
 .../misc-swfmill.all/missing_bitmapTestRunner.cpp  |    4 +++-
 2 files changed, 10 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Gnash