Re: [Gnash-commit] [SCM] Gnash branch, noise, updated. release_0_8_9_final-1172-g16b7a3a

[Sandro Santilli]

On Tue, Sep 13, 2011 at 03:37:27PM +0000, Rob Savoye wrote:

> The branch, noise has been updated
...

> commit 16b7a3aeac7957b4aee5f01c7af1e573f6e3396d
> Author: Rob Savoye <address@hidden>
> Date:   Tue Sep 13 09:37:02 2011 -0600
> 
>     increase the default delay to 50ms

Why so ?
We'd miss any quick timer.
Extensive testing has been done to set that number in order to behave
like the proprietary version. Also, 10ms is what some of the code may
be basing on for loading the sound output queue (see comments about how
44100hz works nicely with 10ms within Sound class and friends).
You can already tweak this number with command line (-d).
What's missing (which could be nice to have) would be configuration
file support. That way any user willing to giveup compatibility
(and maybe some audio smoothness) can tweak that number at runtime.

> commit cac4d53390873466ba710bda7b3512f4d0ec135f
> Author: Rob Savoye <address@hidden>
> Date:   Tue Sep 13 09:36:17 2011 -0600
> 
>     Don't do anything if we have no timers, just return so we don't waste cpu 
> cycles

Good idea !

> +    // Don't do anything if we have no timers, just return so we don't
> +    // waste cpu cycles.
> +    if (_intervalTimers.size() == 0) {
> +        return;
> +    }

.size()==0 is often slower than .empty()

--strk; 

  ()   Free GIS & Flash consultant/developer
  /\   http://strk.keybit.net/services.html