[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnash-commit] [bug #39848] gui/fb/fb.cpp:382:9: warning: variable 'dela
From: |
Sandro Santilli |
Subject: |
[Gnash-commit] [bug #39848] gui/fb/fb.cpp:382:9: warning: variable 'delay' set but not used |
Date: |
Sat, 26 Oct 2013 13:58:59 +0000 |
User-agent: |
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:24.0) Gecko/20100101 Firefox/24.0 |
Update of bug #39848 (project gnash):
Status: Works For Me => Confirmed
_______________________________________________________
Follow-up Comment #3:
The delay variable was introduced by Rob to reduce CPU load by reducing the
heartbeat for SWF apps having a nominal framerate equal or minor to 12 (a
common default). This entered the codebase with this commit:
http://git.savannah.gnu.org/cgit/gnash.git/commit/gui/fb/fb.cpp?id=3bf5e4607b866c336dc4471facdd1c410c8d0e51
But the same support was later (accidentally, I guess?) dropped by himself
with this unrelated commit:
http://git.savannah.gnu.org/cgit/gnash.git/commit/gui/fb/fb.cpp?id=a7af918e32a9bafbe2d545ec591a550d3e430a72
Personally I think the the delay should always be 10ms as before the first
commit (it's requried to be compatible with timer resolution, fps of loaded
movies and/or media, thus not only depending on nominal SWF framerate) and
that CPU load reduction should be done by using a generic switch to control
heartbeat (giving user the possibility to giveup some compatibility to relax
CPU use).
So my vote on this is to just drop the "delay" variable.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?39848>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Gnash-commit] [bug #39848] gui/fb/fb.cpp:382:9: warning: variable 'delay' set but not used,
Sandro Santilli <=