[Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1975-g7d7cce0

[Bastiaan Jacques]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  7d7cce0fd1bbe51f660c0e129ef3dd37acc98100 (commit)
      from  de5c7201f93702938bcd8efcbf8342789043d7bd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=7d7cce0fd1bbe51f660c0e129ef3dd37acc98100


commit 7d7cce0fd1bbe51f660c0e129ef3dd37acc98100
Author: Bastiaan Jacques <address@hidden>
Date:   Sat May 10 01:59:29 2014 +0200

    Plug file descriptor leak. See #42199.

diff --git a/plugin/npapi/plugin.cpp b/plugin/npapi/plugin.cpp
index 609ccb6..86150b9 100644
--- a/plugin/npapi/plugin.cpp
+++ b/plugin/npapi/plugin.cpp
@@ -1419,6 +1419,12 @@ nsPluginInstance::startProc()
     
     // If we are the parent and fork() worked, childpid is a positive integer.
     if (_childpid > 0) {
+        // Close the child's end of the pipes.
+        ret = close(p2c_controlpipe[0]);
+        if (ret == -1) {
+            gnash::log_error("p2c_controlpipe[0] close() failed: %s",
+                             strerror(errno));
+        }
         
         // we want to write to p2c pipe, so close read-fd0
         ret = close (p2c_pipe[0]);

-----------------------------------------------------------------------

Summary of changes:
 plugin/npapi/plugin.cpp |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Gnash