[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_fi
From: |
Sandro Santilli |
Subject: |
Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1982-g66b47f4 |
Date: |
Thu, 15 May 2014 10:40:04 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, May 15, 2014 at 10:33:42AM +0200, Bastiaan Jacques wrote:
> I presume that if I had written > 1 that would have broken single-bit
> reads (if there are any). It is enough, I think, to ensure that the
> bitshift is not negative.
Then I keep not understanding this.
Here's the snippet:
>>>> SWFStream::read_sint(unsigned short bitcount)
>>>> {
>>>> assert(bitcount > 0);
Now I get it. You're asserting for it to be != 0, basically.
Sorry for the noise.
--strk;
- [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1982-g66b47f4, Bastiaan Jacques, 2014/05/14
- Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1982-g66b47f4, Sandro Santilli, 2014/05/15
- Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1982-g66b47f4, Bastiaan Jacques, 2014/05/15
- Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1982-g66b47f4, Sandro Santilli, 2014/05/15
- Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1982-g66b47f4, Bastiaan Jacques, 2014/05/15
- Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1982-g66b47f4,
Sandro Santilli <=
Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1982-g66b47f4, Bastiaan Jacques, 2014/05/16