[Gnash-commit] [bug #42420] potential data races from SWFMovieDefinition::read_all_swf()

[Bastiaan Jacques]

Follow-up Comment #4, bug #42420 (project gnash):

If the parsing is moved to the main thread, then the loaders  may have to be
converted to use a push rather than pull model for the raw data, which could
be a significant undertaking. Alternatively, some sort of threaded loading
could be built into SWFStream itself, which I expect would be simpler.

As an alternative to moving parsing into the main thread, the loaders could be
modified to return their parsing results (rather than modifying
SWFMovieDefinition directly). Then the parsing results would have to be
marshalled back to the main thread regularly.

In either case, there would have to be some point at which the either the
parsing is actually done or the parsing results are loaded into the main
thread, which owns SWFMovieDefinition. Presumably this could happen in
ensure_frame_loaded().

It seems obvious to me that reading from SWFStream (which typically involves
downloading stuff) should be asynchronous, but I'm not so sure about the
parsing done in the loaders. I think we might be able to get away with doing
that synchronously, but I'm not sure.

What do you think?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?42420>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/