[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_fi
From: |
Richard Wilbur |
Subject: |
Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-2104-g0c13c8e |
Date: |
Wed, 4 Jun 2014 22:56:05 -0600 |
Dear Bastiaan,
Looks like a good set of changes. I noticed a couple inconsistencies
that I thought I would point out.
> diff --git a/libcore/asobj/NetConnection_
as.cpp b/libcore/asobj/NetConnection_as.cpp
> index 7a2e7df..e6c7895 100644
> @@ -234,10 +234,10 @@ public:
> //
> /// @param nc The NetConnection AS object to send status/error events
> to
> /// @param url URL to post calls to
> - HTTPConnection(NetConnection_as& nc, const URL& url)
> + HTTPConnection(NetConnection_as& nc, const URL url)
Looks suspiciously like the 'const' survived the cut?
> diff --git a/libcore/Timers.cpp b/libcore/Timers.cpp
> index 289e830..780af76 100644
@@ -38,28 +38,28 @@ Timer::~Timer()
}
Timer::Timer(as_function& method, unsigned long ms,
- as_object* this_ptr, const fn_call::Args& args, bool runOnce)
+ as_object* this_ptr, fn_call::Args args, bool runOnce)
:
_interval(ms),
_start(std::numeric_limits<
unsigned long>::max()),
_function(&method),
_methodName(),
_object(this_ptr),
- _args(args),
+ _args(std::move(args)),
_runOnce(runOnce)
{
start();
}
-Timer::Timer(as_object* this_ptr, const ObjectURI& methodName,
- unsigned long ms, const fn_call::Args& args, bool runOnce)
+Timer::Timer(as_object* this_ptr, ObjectURI methodName,
+ unsigned long ms, fn_call::Args args, bool runOnce)
:
_interval(ms),
_start(std::numeric_limits<unsigned long>::max()),
_function(nullptr),
_methodName(methodName),
In the second Timer constructor, looks like methodName got the
constructor parameter treatment, but missed the std::move() treatment.
Sincerely,
Richard