gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-commit] [patch #8720] Patch for fixing GC-related issue in Extern


From: Bastiaan Jacques
Subject: [Gnash-commit] [patch #8720] Patch for fixing GC-related issue in ExternalInterface registration
Date: Tue, 08 Sep 2015 19:58:08 +0000
User-agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0

Follow-up Comment #2, patch #8720 (project gnash):

+    for (std::map<std::string, as_object*>::const_iterator method_iterator
+             = _externalCallbackMethods.begin();
+         method_iterator != _externalCallbackMethods.end();
+         method_iterator++)

I have a minor quibble with this, and that is that due to the vagaries of C++,
method_iterator++ is actually slower than ++method_iterator.

At any rate, in c2f388e26873b I simply converted these loops to C++11 syntax,
which avoids this issue and is also a lot less typing.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8720>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]