[Gnash-commit] [patch #8738] Patch to correct audio data size in 8 to 16-bit embeded PCM sound conversion (GStreamer backend)

[Nutchanon Wetchasit]

URL:
  <http://savannah.gnu.org/patch/?8738>

                 Summary: Patch to correct audio data size in 8 to 16-bit
embeded PCM sound conversion (GStreamer backend)
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Sun 13 Sep 2015 08:30:27 PM ICT
                Category: sound
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Currently Gnash (GStreamer media handler) has a problem
<https://savannah.gnu.org/bugs/?45722#comment18> on playing
8-bit stereo PCM embeded sound. This was due to wrong output size
<https://savannah.gnu.org/bugs/?45722#comment19>
was given out by the decoder when the sound is stereo.

This patch fixes this issue by correcting the buffer size _multiplier_ used
when the decoder converts 8-bit to 16-bit PCM, which is supposed to be `2`.
(Original code used `4` if the sound is stereo
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libmedia/AudioDecoderSimple.cpp?id=f5016cc9399c9ffd3c5d32c67bb28fac285559c6#n393>,
which it shouldn't, since
stereo expansion and further size multiplication, are done separately
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libmedia/AudioDecoderSimple.cpp?id=f5016cc9399c9ffd3c5d32c67bb28fac285559c6#n461>).

See the attached
`0002_use-correct-audio-block-size-after-16bit-conversion.patch`.

Note: This fix does not cover FFmpeg/libAV media handler.

Gnash: 0.8.11dev (patched against git f5016cc 9-Sep-2015)
SDL: libsdl1.2debian 1.2.15-5 (debian) 
GStreamer: libgstreamer0.10-0 0.10.36-1.2 (debian)
CSound: libcsound64-5.2 1:5.17.11~dfsg-3 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 13 Sep 2015 08:30:28 PM ICT  Name:
0002_use-correct-audio-block-size-after-16bit-conversion.patch  Size: 703B  
By: nachanon
Patch to correct audio block size multiplier in 8 to 16-bit embeded PCM sound
conversion
<http://savannah.gnu.org/patch/download.php?file_id=34869>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8738>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/