|
From: | Sandro Santilli |
Subject: | [Gnash-commit] [patch #8747] Patches to fix 8-bit PCM sound wailing/crashing in FFmpeg media backend |
Date: | Mon, 21 Sep 2015 07:55:51 +0000 |
User-agent: | Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0 |
Follow-up Comment #7, patch #8747 (project gnash): Wow, lots of patches. The signed vs. unsigned change really deserves some inline comment otherwise it'll be hard for anyone reading the code to understand why an unsigned codec is used for an advertised-as-signed one. What about merging all patches in a single one and adding proper comments to explain what's being done ? This is particularly needed as we have NO AUTOMATED TESTS to ensure a regression is not introduced. _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/patch/?8747> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |