[Gnash-commit] [patch #8753] Patch to make `./configure` be descriptive on how Gnash uses Csound

[Nutchanon Wetchasit]

URL:
  <http://savannah.gnu.org/patch/?8753>

                 Summary: Patch to make `./configure` be descriptive on how
Gnash uses Csound
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Sat 26 Sep 2015 03:24:04 PM ICT
                Category: build
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

With current version of Gnash, when user tried to run `./configure` script
without Csound tools <http://www.csounds.com/> installed on the system, it
would show a following message:

        WARNING: You need to have csound installed
                 to have real fun.
                 Install it from http://www.csounds.com/
                 or .deb users: apt-get install csound
                 or .rpm users: yum install csound


Instead of "to have real fun", the message should show _what exactly_ Csound
have to do with Gnash's build process or testing process; allowing user
to make an informed decision whether to install it or not.

In this case, according to `testsuite/media/Makefile.am`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/testsuite/media/Makefile.am?id=f0f66ce7f644a631bbb5f51f78375298fdef3d40#n48>,
Csound is used
for generating some audio files for Gnash's audio-related test cases.

Proposed patch changes the message to:

        WARNING: You need to have csound installed to generate some of 
                 sound-related test files in Gnash testsuite.
                 Install it from http://www.csounds.com/
                 or .deb users: apt-get install csound
                 or .rpm users: yum install csound


Note: this patch uses `PKG_WAR()`, `PKG_SUGGEST()`, `DEB_INSTALL()`,
and `RPM_INSTALL()` macro facility instead of printing directly to fd 4.

Gnash: 0.8.11dev (patched against git f0f66ce 23-Sep-2015)
CSound: libcsound64-5.2 1:5.17.11~dfsg-3 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 26 Sep 2015 03:24:04 PM ICT  Name:
0001_rewrite-configure-csound-message.patch  Size: 947B   By: nachanon
Patch for improving `./configure` message on missing Csound tools
<http://savannah.gnu.org/patch/download.php?file_id=34981>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8753>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/