[Gnash-commit] [patch #8904] Patches to fix special stroke size handling in `MovieClip.lineStyle()`

[Nutchanon Wetchasit]

URL:
  <http://savannah.gnu.org/patch/?8904>

                 Summary: Patches to fix special stroke size handling in
`MovieClip.lineStyle()`
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Fri 05 Feb 2016 01:42:25 PM ICT
                Category: core
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Current Gnash's implementation of `MovieClip.lineStyle()` has an incorrect
handling of `thickness` argument when it have special value like
`undefined` or `Infinity`, a.k.a. bug #45731.

Patch 1 of 2:
See the attached `0001_reset-line-style-on-undefined-stroke.patch`.

Original code of `MovieCLip.lineStyle()` implementation already resets
line style when the method was called without any argument
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/asobj/MovieClip_as.cpp?id=02ec1e61bf5b08a5db29472c268a2e448ac8772a#n1497>,
but it doesn't
reset line style when `thickness` argument is specified as `undefined`,
and left it to number conversion code's interpretation
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/asobj/MovieClip_as.cpp?id=02ec1e61bf5b08a5db29472c268a2e448ac8772a#n1610>,
which results
in hairline (width 0) stroke.

This patch extends the condition check
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/asobj/MovieClip_as.cpp?id=02ec1e61bf5b08a5db29472c268a2e448ac8772a#n1497>
to cover the case where
`thickness` argument is specified, but as `undefined`, which has
essentially the same meaning; partially fixing bug #45731.

Gnash: 0.8.11dev (patched against git 02ec1e6 3-Feb-2016)
System: Debian GNU/Linux 7.0 Wheezy i386




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Fri 05 Feb 2016 01:42:25 PM ICT  Name:
0001_reset-line-style-on-undefined-stroke.patch  Size: 698B   By: nachanon
Patch to make `MovieClip.lineStyle()` disable line drawing on `undefined` line
thickness
<http://savannah.gnu.org/patch/download.php?file_id=36250>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8904>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/