[Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-2258-g435d3e9

[Sandro Santilli]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  435d3e9aa7864883f6a2379fd318126113786475 (commit)
      from  5dd3e016bef83cc0368fa1fdca8ffcb58d811e89 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=435d3e9aa7864883f6a2379fd318126113786475


commit 435d3e9aa7864883f6a2379fd318126113786475
Author: Nutchanon Wetchasit <address@hidden>
Date:   Sat Feb 6 13:01:56 2016 +0100

    Add automated test on delayed return value handling in 
ExternalInterface.call().

diff --git a/testsuite/misc-mtasc.all/extcomm.as 
b/testsuite/misc-mtasc.all/extcomm.as
index cb8eaf3..dcf7862 100644
--- a/testsuite/misc-mtasc.all/extcomm.as
+++ b/testsuite/misc-mtasc.all/extcomm.as
@@ -140,5 +140,18 @@ class ExternalCommTest
                // Calling JavaScript function without any argument should give
                // a correct return value
                check_equals(ExternalInterface.call("js_simple"), "Correct");
+
+               // Calling JavaScript function 20 times in row should give all
+               // correct return value
+               var numreadings:Array = new Array(
+                       "one", "two", "three", "four", "five", "six", "seven", 
"eight",
+                       "nine", "ten", "eleven", "twelve", "thirteen", 
"fourteen",
+                       "fifteen", "sixteen", "seventeen", "eighteen", 
"nineteen", "twenty"
+               );
+               var i:Number;
+               for(i = 0; i < numreadings.length; i++) {
+                       check_equals(ExternalInterface.call("js_readnumber", i 
+ 1),
+                                    numreadings[i]);
+               }
        }
 }
diff --git a/testsuite/misc-mtasc.all/extcommtests-runner.sh 
b/testsuite/misc-mtasc.all/extcommtests-runner.sh
index 6f0d875..8cc8fba 100644
--- a/testsuite/misc-mtasc.all/extcommtests-runner.sh
+++ b/testsuite/misc-mtasc.all/extcommtests-runner.sh
@@ -26,6 +26,8 @@
 # The generated test runner checks Gnash for:
 #  * ExternalInterface.addCallback() issues (bug #37223)
 #        <https://savannah.gnu.org/bugs/?37223>
+#  * ExternalInterface.call()'s delayed return value issue (bug #46131)
+#        <https://savannah.gnu.org/bugs/?46131>
 #  * Single-argument ExternalInterface.call() issue (bug #46878)
 #        <https://savannah.gnu.org/bugs/?46878>
 # 
@@ -195,6 +197,25 @@ check_equals \
 # Return string value from js_simple function
 echo '<string>Correct</string>' >&4
 
+# Test using multiple ExternalInterface.call() in row
+NUMBER=1
+for READING in "one" "two" "three" "four" "five" "six" "seven" "eight" "nine" \
+       "ten" "eleven" "twelve" "thirteen" "fourteen" "fifteen"  "sixteen" \
+       "seventeen" "eighteen" "nineteen" "twenty"
+do
+       # Read for js_readnumber JavaScript function invocation statement
+       read_timeout LINE \$READTIMEOUT <&3
+       check_equals \
+               "\$LINE" \
+               "<invoke name=\"js_readnumber\" 
returntype=\"xml\"><arguments><string>js_readnumber</string><number>\$NUMBER</number></arguments></invoke>"
 \
+               "Gnash should call JavaScript's js_readnumber function with 
parameter \$NUMBER correctly"
+
+       # Return string value from js_readnumber function
+       echo "<string>\$READING</string>" >&4
+
+       NUMBER=\`expr \$NUMBER + 1\`
+done
+
 # Pause a bit, so the next script_call invoke doesn't get mixed up with
 # the previous return value data
 sleep 1
@@ -260,7 +281,7 @@ XFAILED=\`expr "\$XFAILED" + "\$PLAYERXFAILED"\`
 TESTED=\`expr "\$TESTED" + "\$PLAYERPASSED" + "\$PLAYERXPASSED" + 
"\$PLAYERFAILED" + "\$PLAYERXFAILED"\`
 
 # Check for total number of test run
-check_totals "47" "There should be 47 tests run"
+check_totals "87" "There should be 87 tests run"
 
 # Remove temporary files
 rm "\$LOGFILE"

-----------------------------------------------------------------------

Summary of changes:
 testsuite/misc-mtasc.all/extcomm.as             |   13 +++++++++++++
 testsuite/misc-mtasc.all/extcommtests-runner.sh |   23 ++++++++++++++++++++++-
 2 files changed, 35 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Gnash