[Gnash-commit] [patch #8908] Patch to make Gnash interpret path in `GetVariable()` plugin function like ActionGetVariable

[Nutchanon Wetchasit]

URL:
  <http://savannah.gnu.org/patch/?8908>

                 Summary: Patch to make Gnash interpret path in
`GetVariable()` plugin function like ActionGetVariable
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Wed 10 Feb 2016 11:01:36 PM ICT
                Category: core
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Current Gnash's `GetVariable()` plugin function implementation supports only
accessing variable using _bare variable name_
<https://savannah.gnu.org/bugs/?42395#comment25>. When HTML tries to use
slash-colon path to fetch variable, it failed. On Flash Player, slash-colon
path notation similar (if not the same) to ones used in ActionScript's
ActionGetVariable instruction is supported.

This patch changes `GetVariable()` implementation from using
`as_object::get_member()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/movie_root.cpp?id=435d3e9aa7864883f6a2379fd318126113786475#n1601>
to using Gnash's implementation of
ActionGetVariable
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/as_environment.h?id=435d3e9aa7864883f6a2379fd318126113786475#n153>
on `_level0` timeline context; which supports both
bare variable name and slash-colon variable path; fixing bug #42395.

See the attached `0005_use-getvariable-action-path-in-plugin-function.patch`.

Once the patch is applied, `fontlist.html` test
<https://savannah.gnu.org/bugs/?42395#comment3> should give the
expected result, `getvariable-slashcolon.html` test
<https://savannah.gnu.org/bugs/?42395#comment25> should give the
mostly-correct result, and EFF Panopticlick <https://panopticlick.eff.org/>
should show the fingerprint result properly too.

This might need a review since I'm not sure whether the way I used for
creating call stack was a proper one.

Gnash: 0.8.11dev (patched against git 435d3e9 6-Feb-2016) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 10 Feb 2016 11:01:36 PM ICT  Name:
0005_use-getvariable-action-path-in-plugin-function.patch  Size: 1kB   By:
nachanon
Patch to use ActionGetVariable implementation for handling `GetVariable()`
plugin function
<http://savannah.gnu.org/patch/download.php?file_id=36299>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8908>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/