[Gnash-commit] [patch #9016] Improved handling of gstreamer plugin installation returns

[Sandro Santilli]

Follow-up Comment #1, patch #9016 (project gnash):

About movie_root: the only reason why you need movie_root is to get to call
the event callback. The movie_root instance knows about the
"_callbacksHandler" because it was passed to it by gui/Player.cpp (see
root.registerEventCallback).

All media handling classes are created by a factory which is initialized by
the same Player class that passed the EventHandler to movie_root, so I suggest
you pass the same EventHandler _also_ to the MediaHandler, and let
MediaHandler pass it further to the objets it create.

See if doing so makes the patch cleaner.

(looking at the code now I see that RunResource would be already holding an
handler to the MediaHandler so it's not appropriate to create a circular link
there).




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9016>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/