[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-dev] patch for plugin not to call wrapper code after fork
From: |
strk |
Subject: |
Re: [Gnash-dev] patch for plugin not to call wrapper code after fork |
Date: |
Mon, 15 Oct 2007 22:54:23 +0200 |
Doesn't looks harmful to me. As long as it works for anyone (didn't try myself)
I'd commit.
--strk;
On Mon, Oct 15, 2007 at 12:42:05PM +0200, Patrice Dumas wrote:
> Hello,
>
> This is a patch from Martin Stransky. He says that:
> gnash calls the original mozilla(or wrapper) code
> after fork from the child process.
>
> You can have a look at
> https://bugzilla.redhat.com/show_bug.cgi?id=281061
>
> this is a patch for
> plugin/plugin.cpp
>
> Does this patch looks right to you?
>
> --
> Pat
> diff -up gnash-0.8.1/plugin/plugin.cpp.old gnash-0.8.1/plugin/plugin.cpp
> --- gnash-0.8.1/plugin/plugin.cpp.old 2007-08-18 18:48:54.000000000 +0200
> +++ gnash-0.8.1/plugin/plugin.cpp 2007-10-15 10:44:16.000000000 +0200
> @@ -490,6 +490,14 @@ nsPluginInstance::startProc(Window win)
> procname = gnash_env;
> }
>
> + const char* pageurl = getCurrentPageURL();
> + if ( ! pageurl )
> + {
> + cout << "Could not get current page URL!" << endl;
> + //log_msg("UNIMPLEMENTED: current page url: %s", pageurl);
> + // invoke gnash with -U <current_page_url>
> + }
> +
> struct stat procstats;
>
> // See if the file actually exists, otherwise we can't spawn it
> @@ -558,13 +566,6 @@ nsPluginInstance::startProc(Window win)
>
> // setup the command line
>
> - const char* pageurl = getCurrentPageURL();
> - if ( ! pageurl )
> - {
> - cout << "Could not get current page URL!" << endl;
> - //log_msg("UNIMPLEMENTED: current page url: %s", pageurl);
> - // invoke gnash with -U <current_page_url>
> - }
>
> const size_t buf_size = 30;
> char xid[buf_size], width[buf_size], height[buf_size];
> _______________________________________________
> Gnash-dev mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnash-dev
--
() ASCII Ribbon Campaign
/\ Keep it simple!