Re: [Gnash-dev] static source code analysis

[strk]

On Sun, Sep 07, 2008 at 12:15:32PM -0700, Bastiaan Jacques wrote:

> [libcore/SWFStream.cpp:326]: Array index out of bounds
> [libcore/SWFStream.cpp:327]: Array index out of bounds
> [libcore/SWFStream.cpp:328]: Array index out of bounds
> [libcore/SWFStream.cpp:329]: Array index out of bounds

I was curious and took a look at this one:

    const unsigned short dataLength = 8;
    unsigned char buf[dataLength];

    // Should align:
    if (read(reinterpret_cast<char*>(buf), dataLength) < dataLength)
    {
        throw ParserException(_("Unexpected end of stream while reading"));
    }

    uint64_t low = buf[0];
    low |= buf[1] << 8;
    low |= buf[2] << 16;
    low |= buf[3] << 24;

    uint64_t hi = buf[4];   <---- line 326
    hi |= buf[5] << 8;
    hi |= buf[6] << 16;
    hi |= buf[7] << 24;

I don't see the out of bounds access...

--strk;