gnats/113: Internal call to 'query-pr' from 'edit-pr' fails with expected results

[opel]

>Number:         113
>Category:       gnats
>Synopsis:       Internal call to 'query-pr' from 'edit-pr' fails with expected 
>results
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Oct 18 13:04:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Steffen Opel
>Release:        gnats-4.0-alpha
>Organization:
>Environment:
Linux gg.geekgadgets.org 2.2.16-22 #1 Tue Aug 22 16:49:06 EDT 2000 i686 unknown
>Description:
'edit-pr' calls 'query-pr' internally in order to verify field requirements 
etc.  Since 'query-pr' isn't in the PATH this call fails with expected results, 
see fix below.
>How-To-Repeat:
Run 'edit-pr' and change a field to trigger the verification and see the 
failure.
>Fix:
Index: gnats/Makefile.in
===================================================================
RCS file: /cvs/gnats/gnats/gnats/Makefile.in,v
retrieving revision 1.36
diff -c -r1.36 Makefile.in
*** Makefile.in 2000/08/02 21:46:18     1.36
--- Makefile.in 2000/10/18 19:50:57
***************
*** 292,297 ****
--- 292,298 ----
  edit-pr: edit-pr.sh Makefile
        @echo Creating edit-pr...
        @sed -e 's,xGNATS_DEFAULT_DB_DIRx,$(GNATS_DEFAULT_DB_DIR),g' \
+            -e 's,xBINDIRx,$(bindir),g' \
             -e 's,xLIBEXECDIRx,$(libexecdir),g' \
             -e 's,xVERSIONx,$(VERSION),g' $(srcdir)/edit-pr.sh > address@hidden
        @mv address@hidden $@
***************
*** 309,314 ****
--- 310,316 ----
        @echo Creating mail-query...
        @sed -e 's,xGNATS_DEFAULT_DB_DIRx,$(GNATS_DEFAULT_DB_DIR),g' \
            -e 's,xBINDIRx,$(bindir),g' \
+             -e 's,xLIBEXECDIRx,$(libexecdir),g' \
            $(srcdir)/mail-query.sh > address@hidden
        @mv address@hidden $@
        @chmod a+x $@
Index: gnats/edit-pr.sh
===================================================================
RCS file: /cvs/gnats/gnats/gnats/edit-pr.sh,v
retrieving revision 1.11
diff -c -r1.11 edit-pr.sh
*** edit-pr.sh  2000/03/28 23:30:26     1.11
--- edit-pr.sh  2000/10/18 19:50:57
***************
*** 28,33 ****
--- 28,36 ----
  locked=
  version=xVERSIONx

+ PATH=xBINDIRx:/bin:/sbin:/usr/bin:/usr/ucb:/usr/bsd:/usr/sbin
+ export PATH
+
  usage="
  Usage: edit-pr  [-V|--version] [-h|--help] [-d|--database database_name]
                  [-H|--host hostname] [-P|--port port_number]
Index: gnats/ChangeLog
===================================================================
RCS file: /cvs/gnats/gnats/gnats/ChangeLog,v
retrieving revision 1.159
diff -c -r1.159 ChangeLog
*** ChangeLog   2000/08/23 19:55:22     1.159
--- ChangeLog   2000/10/18 19:50:57
***************
*** 1,3 ****
--- 1,8 ----
+ 2000-10-18  Steffen Opel  <address@hidden>
+
+       * edit-pr.sh (PATH): Added in order to find query-pr.
+       * Makefile.in (edit-pr): Substitute BINDIR.
+
  Wed Aug 23 12:49:59 2000  Bob Manson  <address@hidden>

        * pr.c (verifyMultiEnum): Accept NULL values if the field doesn't
>Release-Note:
>Audit-Trail:
>Unformatted: