Re: gnats/270: Gnats 4 Compilation Failed [PATCH]

[Yngve Svendsen]

The following reply was made to PR gnats/270; it has been noted by GNATS.

From: Yngve Svendsen <address@hidden>
To: address@hidden, address@hidden
Cc: Milan Zamazal <address@hidden>
Subject: Re: gnats/270: Gnats 4 Compilation Failed [PATCH]
Date: Wed, 03 Oct 2001 13:49:58 +0200

 At 10:09 02.10.2001 +0000, address@hidden wrote:
 >cc1: warnings being treated as errors
 >misc.c: In function `read_line':
 >misc.c:347: warning: signed and unsigned type in conditional expression
 >misc.c:349: warning: signed and unsigned type in conditional expression
 
 The attached patch should fix it.
 
 Yngve Svendsen
 
 
 Index: misc.c
 ===================================================================
 RCS file: /cvs/gnats/gnats/gnats/misc.c,v
 retrieving revision 1.33
 diff -u -p -r1.33 misc.c
 --- misc.c      2001/09/06 19:00:19     1.33
 +++ misc.c      2001/10/03 11:45:07
 @@ -344,9 +344,9 @@ read_line (FILE *input, size_t *max_len_
     size_t len = 0;
     size_t max_len = (max_len_arg != NULL ? *max_len_arg : 0);
     const int default_len = 512;
 -  char *res = xmalloc (max_len>0 ? max_len+1 : default_len);
 +  char *res = xmalloc (max_len>0 ? max_len+1 : (size_t)default_len);
 
 -  while (fgets (res+len, (max_len>0 ? max_len : default_len), input) != NULL)
 +  while (fgets (res+len, (max_len>0 ? max_len : (size_t)default_len), 
 input) != NULL)
       {
         size_t slen = strlen (res + len);
         len += slen;