gnokii-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-34


From: Pawel Kot
Subject: [SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-348-g6248e1d
Date: Mon, 26 Dec 2011 10:53:49 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "libgnokii and core programs".

The branch, master has been updated
       via  6248e1d564cb1f528fc963301534136f7f190b50 (commit)
      from  97cfd69cc017702507d4e644a522a2916de6b546 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/gnokii.git/commit/?id=6248e1d564cb1f528fc963301534136f7f190b50


commit 6248e1d564cb1f528fc963301534136f7f190b50
Author: Pawel Kot <address@hidden>
Date:   Mon Dec 26 11:52:11 2011 +0100

    Do not issue ATZ after device initialization.
    
    If the connect_script is run, do not issue ATZ command afterwards. Either
    the device is reset already or ATZ may invalidate settings done in the
    connect_script.

diff --git a/common/phones/atgen.c b/common/phones/atgen.c
index b677436..4db9ef8 100644
--- a/common/phones/atgen.c
+++ b/common/phones/atgen.c
@@ -3297,7 +3297,17 @@ static gn_error Initialise(gn_data *setupdata, struct 
gn_statemachine *state)
 
        sm_initialise(state);
 
-       SoftReset(&data, state);
+       /*
+        * If there is an initialization script, resetting the device most
+        * likely does not make sense.  Either the script resets the device
+        * or resetting might not be good thing after intialization.
+        */
+       if (!state->config.connect_script[0])
+               SoftReset(&data, state);
+       /*
+        * These might be done in the connect script as well, but gnokii
+        * behaviour depends on it, so make sure these are issued.
+        */
        SetEcho(&data, state);
        SetExtendedError(&data, state);
 

-----------------------------------------------------------------------

Summary of changes:
 common/phones/atgen.c |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
libgnokii and core programs



reply via email to

[Prev in Thread] Current Thread [Next in Thread]