Re: Patch #216 on savannah

[BORBELY Zoltan]

Hello,

On Thu, Apr 04, 2002 at 04:48:33PM +0200, Feico de Boer wrote:
> I get an severe compile error  where GCC complains about 'parse error'.
> 
> /usr/include/sys/unistd.h:106: parse error before `('
> /usr/include/sys/unistd.h:137: parse error before `('
> 
> unistd.h:106:unsigned _EXFUN(sleep, (unsigned int __seconds ));
> unistd.h:137:unsigned _EXFUN(usleep, (unsigned int __useconds));

oops. Try to comment out sleep and usleep macros from misc.h, maybe this
cause the problem.

> Leaves me with the question: why using a system include after the 'own'
> includes? I think it is in general a bad idea to have system includes after
> own includes unless you can give me a solid reason for this. IMHO it should
> not be done because you might break the consistancy of the defined types (as
> I think happened here also).

Yes, I moved this header after own headers yesterday. The reason is quite
simple. I was too lazy to put #include "config.h" before it. I'll correct
it this night.

> This is what happened after preprocessing:
> unsigned __attribute__((__cdecl__))   Sleep(( unsigned int __seconds  ) *
> 1000)  ;

Yes, I'm quite sure the sleep() and usleep() macros in misc.h cause this
problem. IMHO it's a Cygwin specific problem (HAVE_CONFIG_H and WIN32 must
be defined to bomb). I'll correct it too.

> mean that the following policy is needed:
>     1)    include "misc.h"

s/misc.h/config.h/

>     2)    include system includes
>     3)    include own includes

I'm waiting for your reply... :-)

Bye,
Bozo