Re: xgnokii segfaults on empty ringtones list

[Daniele Forsi]

Pawel Kot ha scritto:

> Try the attached patch.

it works, thank you!

Now I can load and save ringtones from file; when I bang on the piano 
keyboard nothing happens (both using the mouse and the QWERTY keys); I 
can play through the phone a ringtone loaded from file, but if I change 
name and tempo the new values aren't saved.

I have an idea why the ringtones list is empty

I have a Nokia 3330 and in common/phones/nk6100.c I see this at line 2755
        req[3] = data->ringtone->location - 17;

this phone supports 7 user defined ringtones and I can get them as 
numbers 17-23 but then they aren't decoded

$ gnokii --getringtone myfile 17

NOKIA RAW RINGTONE DECODING FAILED
ringtone:
0000 c4 04 00 17 1c ca e9 34 44 93 22 4e 11 46 08 00
0010 00 00 00 1c 00 13 03 bc 2b 70 6e 67 00 00 00 00
0020 00 00 00 0c 00 12 fd 9c 00 00 00 00 00 00 00 00
0030 00 00 01 1d 00 00 00 07 91 93 43 29 00 30 58 00
0040 04 00 5b 00 04 00 00 32 0c 91 93 43 48 39 46 02
0050 00 00 00 00 20 40 30 01 35 70 08 d3 24 d3 9a 0c
0060 82 84 47 50 10 44 2d b2 90 c1 24 88 2a 7d 5a 83
0070 d4 27 88 19 04 09 9f 4c 66 91 4a 0d 82 9c 45 26
0080 f3 09 9a 0e 83 d4 1f 00 00 00 00 00 00 00 00 00
0090 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00a0 01 01 1f 00 00 00 00 00 00 00 00 00 00 00 00 00
00b0 00 00 00 00 00 00 85 01 00 02 0a 01 00 00 00 00
00c0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00d0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00e0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00f0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0100 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0110 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00offset: 0000
Please read Docs/Bugs and send a bug report!
Getting ringtone 17 failed: Data format is not valid.

--
Daniele