Re: [Gnu-arch-users] Binary Diff System in Arch

[Robert Collins]

On Thu, 2004-02-05 at 04:59, Andrew Suffield wrote:
> On Wed, Feb 04, 2004 at 08:59:18AM -0800, Tom Lord wrote:
> > * tla binary file detection
> > 
> >   tla trusts diff to detect binary files.  It uses a crude
> >   technique: looking for the the string "binary files" at the 
> >   start of diff output.   Strangely enough, this seems to work
> >   regardless of how a users locale is set.
> 
> That's odd, because it shouldn't. That message is i18ned, and l10ned
> in most of the po files I have here - and if I trivially test it, I
> get an l10ned message. Why it works for tla is a mystery that really
> should be investigated.
> 
> tla should probably override LC_MESSAGES and LC_ALL before invoking
> diff.

IIRC diff returns 2 for binary files, AND outputs said message. Arch
looks for the return code first, the message second. You're right
though, we should override the locale.

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.

signature.asc
Description: This is a digitally signed message part