[Gnu-arch-users] [BUG] [PATCH] Problem with archive names starting with numbers

[Jan Hudec]

Severity: normal
External: savannah 7072

When id tagging method does not allow name tags and there is a patch log
from archive starting with number (or other non-alphabetic character),
arch complains that the directory under {arch} containing patchlogs from
this archive is not tagged and insist on adding an explicit tag.

This bug was closed in savannah BTS some time ago, but was not actualy
fixed. The archive still does not work.

Since arch does not allow anything but alphanumerics, ., @ and - in
archive names, this fix should be correct:

--- tla-20040103/src/tla/libarch/inv-ids.c.orig 2004-01-03 12:42:16.000000000 
+0100
+++ tla-20040103/src/tla/libarch/inv-ids.c      2004-01-03 19:08:19.000000000 
+0100
@@ -1165,7 +1165,7 @@
     {
       int re_error;
 
-      re_error = regcomp (&pattern, 
"^(.*/)?(\\{arch\\}(/[a-zA-Z=][^/~]*)*|\\{arch\\}/\\.arch-project-tree)$", 
REG_EXTENDED);
+      re_error = regcomp (&pattern, 
"^(.*/)?(\\{arch\\}(/[a-zA-Z0-9.=-][^/~]*)*|\\{arch\\}/\\.arch-project-tree)$", 
REG_EXTENDED);
       invariant (!re_error);
       compiled = 1;
     }

Alternative is to say that anything containing @-sign is correct under
{arch}:

--- tla-20040103/src/tla/libarch/inv-ids.c.orig 2004-01-03 12:42:16.000000000 
+0100
+++ tla-20040103/src/tla/libarch/inv-ids.c      2004-01-03 19:08:19.000000000 
+0100
@@ -1165,7 +1165,7 @@
     {
       int re_error;
 
-      re_error = regcomp (&pattern, 
"^(.*/)?(\\{arch\\}(/[a-zA-Z=][^/~]*)*|\\{arch\\}/\\.arch-project-tree)$", 
REG_EXTENDED);
+      re_error = regcomp (&pattern, 
"^(.*/)?(\\{arch\\}(/[a-zA-Z=][^/~]*|[^/address@hidden/~]*)*|\\{arch\\}/\\.arch-project-tree)$",
 REG_EXTENDED);
       invariant (!re_error);
       compiled = 1;
     }

-------------------------------------------------------------------------------
                                                 Jan 'Bulb' Hudec 
<address@hidden>