[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnu-arch-users] RE: patch: clean up some cacherev mess
From: |
Derek Zhou |
Subject: |
[Gnu-arch-users] RE: patch: clean up some cacherev mess |
Date: |
Sat, 19 Nov 2005 11:57:04 -0800 |
There are already lots of tmp_file_name ("/tmp", ",,bluh"); in the tree
so I don't see the point of doing this here. Maybe eventually we can
cleean up all of those to obey TMPDIR.
Derek
> -----Original Message-----
> From: Matthieu Moy [mailto:address@hidden
> Sent: Saturday, November 19, 2005 3:50 AM
> To: Derek Zhou
> Cc: address@hidden; address@hidden
> Subject: Re: patch: clean up some cacherev mess
>
> Derek Zhou <address@hidden> writes:
>
> > --- orig/libarch/archive-cache.c
> > +++ mod/libarch/archive-cache.c
> > @@ -27,7 +27,7 @@
> > t_uchar * tmp_dir = 0;
> > t_uchar * pristine_dir = 0;
> >
> > - tmp_dir = tmp_file_name (".", ",,archive-cache-revision");
> > + tmp_dir = tmp_file_name ("/tmp", ",,archive-cache-revision");
> > pristine_dir = file_name_in_vicinity (0, tmp_dir, revision);
> >
> > safe_mkdir (tmp_dir, 0777);
> >
> >
>
> "/tmp/" should be something like tmp_dir(...) (with the appropriate
> "free") to obey TMPDIR.
>
> --
> Matthieu
>
- [Gnu-arch-users] RE: patch: clean up some cacherev mess,
Derek Zhou <=
- RE: [Gnu-arch-users] Re: patch: clean up some cacherev mess, Derek Zhou, 2005/11/19
- RE: [Gnu-arch-users] Re: patch: clean up some cacherev mess, Derek Zhou, 2005/11/20
- RE: [Gnu-arch-users] Re: patch: clean up some cacherev mess, Derek Zhou, 2005/11/20
- RE: [Gnu-arch-users] Re: patch: clean up some cacherev mess, Derek Zhou, 2005/11/21
- RE: [Gnu-arch-users] Re: patch: clean up some cacherev mess, Derek Zhou, 2005/11/21