Re: [Gnu-arch-users] TLA: patches for neon >= 0.25.2 and others

[Thomas Lord]

FYI (i.e., perhaps to make decisions easier to make well):

As I recall, at the time tla started using neon, neon was
advertised to have an unstable API and work on later
versions were underway.

Therefore, I fixed tla at one particular version, bundling it
in the same tar file.   The intention was just to keep the two
release cycles (tla, neon) loosely coupled.

That choice was made on the necessarily optimistic assumption
that tla was sufficiently interesting as to merit R&D investment
and that, therefore, it would find R&D investment and, therefore,
it would be easy to later re-sync with neon.

The optimistic assumption was necessary to doing *anything* with
tla -- but at least part of it was false.   So, re-sync never occurred.

-t



Stephen J. Turnbull wrote:
> This will screw anybody with an earlier neon, and perhaps a later one,
> for that matter: the neon developers don't hesitate to change their
> ABIs, as we see here.  You have to provide a proper configuration
> script to handle it.
>
> Debarshi 'Rishi' Ray writes:
>  > When built with neon >= 0.25.2, tla-1.3.5 crashes. Some distributions
>  > (eg., Fedora) prefer to build packages against the system's libraries
>  > instead of libraries embedded in a upstream tarball -- in this case,
>  > libneon.The problem was reported in both Debian and Fedora:
>  > 
>  > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=402952
>  > https://bugzilla.redhat.com/show_bug.cgi?id=327111
>  > 
>  > The tla package in Fedora uses the following patch to fix this issue:
>  > 
>  > diff -urNp tla-1.3.5.orig/src/tla/libarch/pfs-dav.c
>  > tla-1.3.5/src/tla/libarch/pfs-dav.c
>  > --- tla-1.3.5.orig/src/tla/libarch/pfs-dav.c      2007-12-13 
> 22:51:47.000000000 +0530
>  > +++ tla-1.3.5/src/tla/libarch/pfs-dav.c   2007-12-13 22:54:36.000000000 +0530
>  > @@ -128,7 +128,7 @@ static t_uchar * abs_path (const t_uchar
>  >                             const t_uchar * path);
>  >  static t_uchar * dirfold (t_uchar *dir);
>  >  static void results (void * userdata,
>  > -                     const char * uri,
>  > +                     const ne_uri * uri,
>  >                       const ne_prop_result_set * set);
>  > 
>  >  
>  > @@ -988,22 +988,23 @@ dirfold (t_uchar *dir)
>  > 
>  >  static void
>  >  results (void * userdata,
>  > -         const char * uri,
>  > +         const ne_uri * uri,
>  >           const ne_prop_result_set * set)
>  >  {
>  >    int n;
>  > -  char * file, * tmp;
>  > +  char * file, * href, * tmp;
>  >    struct ls_data * data = userdata;
>  > 
>  > -  if (str_cmp (data->uri, uri))
>  > +  href = ne_uri_unparse (uri);
>  > +  if (str_cmp (data->uri, href))
>  >      {
>  > -      if (1 == (n = str_length (uri)))
>  > +      if (1 == (n = str_length (href)))
>  >          return;
>  > 
>  > -      if (uri[n - 1] == '/')
>  > +      if (href[n - 1] == '/')
>  >          n--;
>  > 
>  > -      file = str_chr_rindex_n (uri, n, '/') + 1;
>  > +      file = str_chr_rindex_n (href, n, '/') + 1;
>  > 
>  >        n = str_length (file);
>  >        if (file[n - 1] == '/')
>  > @@ -1015,6 +1016,7 @@ results (void * userdata,
>  > 
>  >        data->files = str_realloc_cat_many (0, data->files, tmp,
>  > "\r\n", str_end);
>  >        free (tmp);
>  > +      free (href);
>  >      }
>  >  }
>  > 
>  > You may find other patches used in the Fedora package (some of them
>  > borrowed from Debian) here:
>  > http://cvs.fedoraproject.org/viewcvs/rpms/tla/devel/
>  > 
>  > Is this alright with you? If yes, would you include them in the next release?
>  > 
>  > Happy hacking,
>  > Debarshi
>  > -- 
>  > Free software for the Indian community:
>  > * ftp://fedora.glug-nith.org/ (Fedora)
>  > * http://gnu.glug-nith.org/ (GNU)
>  > * http://mirror.wbut.ac.in/ (CRAN, Fedora, Mozilla, TLDP)
>  > 
>  > 
>  > _______________________________________________
>  > Gnu-arch-users mailing list
>  > address@hidden
>  > http://lists.gnu.org/mailman/listinfo/gnu-arch-users
>  > 
>  > GNU arch home page:
>  > http://savannah.gnu.org/projects/gnu-arch/
>
>
> _______________________________________________
> Gnu-arch-users mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnu-arch-users
>
> GNU arch home page:
> http://savannah.gnu.org/projects/gnu-arch/
>
>