Re: [GNU Crypto] Adding new block ciphers; encrypt() not defined anywhere?

[Raif S. Naffah]

hello Morgon,

On Monday 29 May 2006 09:35, Morgon Kanter wrote:
> Hello,
>
> I'm currently in the process of trying to add block ciphers to GNU
> Crypto, and I've run across something I've found to be a bit odd.
>
> Every block cipher's function encryptBlock() and decryptBlock() call
> the functions encrypt() and decrypt(), as defined in the
> BaseBlockCipher class, which every block cipher extends. However,
> encrypt() and decrypt() are left to be defined to the children. So,
> would it make sense to add something like:
>
> protected abstract void encrypt(parameters);
> protected abstract void decrypt(parameters);
>
> to the BaseBlockCipher class? It just seems to me like a strange
> omission.

in a way that's what BaseCipher does by implementing both IBlockCipher 
(the [encrypt|decrypt]Block operations) and IBlockCipherSpi (the 
[encrypt|decrypt] operations).


cheers;
rsn

pgpsP3E1sjC_b.pgp
Description: PGP signature