[gnuastro-commits] (no subject)

[Mohammad Akhlaghi]

branch: master
commit 12a54d28360a82c69d0a98e736a6681051ea4ace
Author: Mohammad Akhlaghi <address@hidden>
Date:   Wed May 25 11:35:53 2016 +0900

    No log files generated during tests
    
    When the tests are run on multiple threads (with `make check -jN', N>1),
    the log files generated by some of the utilities can cause complications
    and thus failures. The cause of the problem is that currently the log files
    of each utility have the same name, irrespective of their input.
    
    Therefore to avoid such wrong FAIL results, all log files are disabled in
    the tests using the configuration files that are set in the
    `tests/prepconf.sh' script (first test).
---
 tests/prepconf.sh |   21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/tests/prepconf.sh b/tests/prepconf.sh
index bcfdc45..437ec72 100755
--- a/tests/prepconf.sh
+++ b/tests/prepconf.sh
@@ -48,11 +48,20 @@ fi
 #     configuration files from older versions). If the option names have
 #     changed or an option has been removed, such sitations will cause a
 #     failed test.
+#
+#   - When checking on multiple threads, the log files generated by the
+#     utilities can get mixed and cause failures, so it is better for the
+#     utility test scripts to not generate any log files. In the utility
+#     design, it is best that a fatal error is reported on the standard
+#     error (which will be recorded in the test outputs), not in a log
+#     file. However, a solution that would allow us to keep the log files
+#     would be to make the log file names depend on the input filenames.
 cat > addedoptions.txt <<EOF
 
 
 # Added only for "make check":
-onlydirconf           1
+ onlydirconf           1
+ nolog                 1
 EOF
 
 
@@ -76,3 +85,13 @@ do
         > .gnuastro/ast$prog.conf
 
 done
+
+
+
+
+
+# Clean up
+# --------
+#
+# Delete the `addedoptions.txt' file that was generated here.
+rm addedoptions.txt