Re: [open-cobol-list] Team setup

[Bernard Giroud]

----- Original Message -----
From: "Henry Eon" <address@hidden>
To: "Giroud, Bernard" <address@hidden>
Cc: "open-cobol" <address@hidden>
Sent: Saturday, October 30, 2004 10:37 AM
Subject: Re: [open-cobol-list] Team setup


>
> Hi Bernard,
>
> you wrote:
>
> >...
> >into a signed long in the first case. BTW, it seems that mpz_fits_slong_p
> >return false in that case, which I don't understand :-((.
> >
> >
> BTW ... What does it means ?
> I don't see any call to mpz_fits_slong_p() in the modified function.
> And so I don't understand either.

True; that was a trial I made with no success. So, not in the final code.

>
> >...
> >The modified routine is at the end of this mail. It seems to be OK,
> >and no regression.
> >
> >Could you tell me if it seems allright to commit ?
> >
> >
> Yes, it seems OK now.
> Thanks for your explanations. I have to learn about gmp !
>
> I think the first call to mpz_get_si() is useless and this line should
> be removed.
> This the last line of the followings.
>
> >static int
> >cob_decimal_get_binary (cob_decimal *d, cob_field *f, int opt)
> >{
> >  int overflow = 0;
> >  int digits = f->attr->digits;
> >  if (f->size <= sizeof (long))
> >    {
> >      if (COB_FIELD_HAVE_SIGN (f))
> > {
> >   long val;
> >   val = mpz_get_si (d->value);
> >
> >
> >
> Cheers,
> Henry

You're perfectly right !

I'll try to commit it tonight or tomorrow morning.

I also agree with Roger's comments regarding truncation checks.

I think in general it should be against a power of 2.

But I don't want to hurry too much.

Bernard Giroud
Credit Lyonnais (Suisse) SA



********************************************************************************
This e-mail contains confidential information or information belonging 
to the Credit Lyonnais Group entity sending it and is intended solely 
for the addressees. Any views expressed in this message are those of 
the individual sender and its contents do not constitute a commitment 
by Credit Lyonnais unless confirmed by letter or fax. The unauthorised 
disclosure, use, dissemination or copying (either whole or partial) of 
this e-mail, or any information it contains, is prohibited. E-mails are 
susceptible to alteration and their integrity cannot be guaranteed.
Internet communications are not secured and therefore Credit Lyonnais 
shall not be liable for this e-mail if modified or falsified. If you 
are not the intended recipient of this e-mail, please delete it 
immediately from your system and notify the sender of the wrong 
delivery and the mail deletion.
********************************************************************************