[gnugo-devel] regression patch

[Gunnar Farneback]

This patch revises some regression tests and adds a few new ones. It
also makes the changes to the life test suites which I proposed in an
earlier message. It has been added to CVS.

/Gunnar

Index: regression/Makefile.am
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/Makefile.am,v
retrieving revision 1.15
diff -u -r1.15 Makefile.am
--- regression/Makefile.am      2001/10/28 14:38:17     1.15
+++ regression/Makefile.am      2001/11/09 17:13:45
@@ -1,5 +1,5 @@
 TST = life.tst owl.tst optics.tst reading.tst strategy.tst \
-      ld_owl.tst ld_owl_life.tst connection.tst  \
+      ld_owl.tst connection.tst  \
       neurogo.tst arb.tst strategy2.tst strategy3.tst rosebud.tst \
       heikki.tst golife.tst dniwog.tst strategy4.tst \
       nicklas1.tst nicklas2.tst nicklas3.tst nicklas4.tst nicklas5.tst \
@@ -76,9 +76,6 @@
 ld_owl: ld_owl.tst
        $(srcdir)/eval.sh ld_owl.tst
 
-ld_owl_life: ld_owl_life.tst
-       $(srcdir)/eval.sh ld_owl_life.tst --life
-
 connection: connection.tst
        $(srcdir)/eval.sh connection.tst
 
@@ -178,13 +175,12 @@
 
 all_batches: first_batch second_batch third_batch fourth_batch
 
-first_batch: reading.tst owl.tst owl_rot.tst ld_owl.tst optics.tst life.tst 
filllib.tst atari_atari.tst connection.tst blunder.tst strategy.tst
+first_batch: reading.tst owl.tst owl_rot.tst ld_owl.tst optics.tst filllib.tst 
atari_atari.tst connection.tst blunder.tst strategy.tst
        $(srcdir)/regress.sh $(srcdir) reading.tst
        $(srcdir)/regress.sh $(srcdir) owl.tst
        $(srcdir)/regress.sh $(srcdir) owl_rot.tst
        $(srcdir)/regress.sh $(srcdir) ld_owl.tst
        $(srcdir)/regress.sh $(srcdir) optics.tst
-       $(srcdir)/regress.sh $(srcdir) life.tst --life
        $(srcdir)/regress.sh $(srcdir) filllib.tst
        $(srcdir)/regress.sh $(srcdir) atari_atari.tst
        $(srcdir)/regress.sh $(srcdir) connection.tst
Index: regression/arb.tst
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/arb.tst,v
retrieving revision 1.12
diff -u -r1.12 arb.tst
--- regression/arb.tst  2001/11/07 05:41:30     1.12
+++ regression/arb.tst  2001/11/09 17:13:45
@@ -30,6 +30,7 @@
 150 gg_genmove white
 #? [J5]
 
+# Why is this move so urgent? /gf
 loadsgf games/arb/dumonteil-2.sgf 229
 200 gg_genmove black
 #? [F14]*
Index: regression/connection.tst
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/connection.tst,v
retrieving revision 1.9
diff -u -r1.9 connection.tst
--- regression/connection.tst   2001/11/07 05:41:30     1.9
+++ regression/connection.tst   2001/11/09 17:13:45
@@ -111,6 +111,10 @@
 31 disconnect R13 S8
 #? [1 Q9]*
 
+loadsgf games/incident240.sgf 69
+32 disconnect B12 E9
+#? [1 D9]
+
 # Report number of nodes visited by the tactical reading
 10000 get_reading_node_counter
 #? [0]&
Index: regression/filllib.tst
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/filllib.tst,v
retrieving revision 1.9
diff -u -r1.9 filllib.tst
--- regression/filllib.tst      2001/10/09 17:56:17     1.9
+++ regression/filllib.tst      2001/11/09 17:13:45
@@ -12,7 +12,7 @@
 # incident 187
 loadsgf games/incident187.sgf 227
 3 gg_genmove white
-#? [B15|A15|A17]
+#? [B15|A15|A17|B14]
 4 gg_genmove black
 #? [B19|A17]
 
Index: regression/global.tst
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/global.tst,v
retrieving revision 1.5
diff -u -r1.5 global.tst
--- regression/global.tst       2001/11/07 05:41:30     1.5
+++ regression/global.tst       2001/11/09 17:13:45
@@ -75,8 +75,11 @@
 19 gg_genmove black
 #? [F14]
 
+# This test should surely have white to move. Still R15 doesn't look
+# like the only move. Changed from "gg_genmove black" to "gg_genmove
+# white" /gf
 loadsgf golois/Goemate990907-2.sgf
-20 gg_genmove black
+20 gg_genmove white
 #? [R15]*
 
 loadsgf golois/Goemate990911-1.sgf
Index: regression/ld_owl_life.tst
===================================================================
RCS file: ld_owl_life.tst
diff -N ld_owl_life.tst
--- /tmp/cvsiDOSO7      Fri Nov  9 12:13:50 2001
+++ /dev/null   Sat Apr 14 20:46:23 2001
@@ -1,208 +0,0 @@
-# Reset life node counter
-reset_life_node_counter
-# Reset owl node counter
-reset_owl_node_counter
-# Reset reading node counter
-reset_reading_node_counter
-
-# Life and death test problems.
-loadsgf games/life_and_death/ld1.sgf
-1 dragon_status B18
-#? [critical (A15|A18) (A15|A18)]
-2 dragon_status S18
-#? [critical (T18|O18) T18]
-3 dragon_status S2
-#? [critical S1 (S1|S7)]
-4 dragon_status B2
-#? [critical (A2|F2) (A2|F2)]
-
-loadsgf games/life_and_death/ld2.sgf
-5 dragon_status B18
-#? [critical (B19|E19) (B19|E19|F18|F19)]
-6 dragon_status S18
-#? [dead]
-7 dragon_status S2
-#? [dead]
-8 dragon_status B2
-#? [critical A2 (A2|A5|B6|A6)]
-
-loadsgf games/life_and_death/ld3.sgf
-9 dragon_status B18
-#? [critical A14 (A17|A14|B13|A13)]
-10 dragon_status S18
-#? [critical T15 (T15|S14|T14)]
-11 dragon_status S2
-#? [critical (S6|T6|T7|T2) S6]
-# Attacking on F1 only gives a ko, which is a failure.
-12 dragon_status B2
-#? [critical B1 (E1|E2|B1)]*
-
-loadsgf games/life_and_death/ld4.sgf
-13 dragon_status B18
-#? [dead]
-14 dragon_status S18
-#? [critical P18 (P18|R19)]
-15 dragon_status S2
-#? [critical T5 (S5|T6|T5)]*
-16 dragon_status B2
-#? [critical A2 (B5|A6|A5|A2)]
-
-loadsgf games/life_and_death/ld5.sgf
-17 dragon_status B18
-#? [critical A14 (A14|B17|A17|A18)]
-18 dragon_status S18
-#? [critical T17 (S17|T17|T18)]
-19 dragon_status S2
-#? [critical (S3|T5) (S3|T5)]
-20 dragon_status B2
-#? [critical (B3|A2|A6) (A2|B3)]
-
-loadsgf games/life_and_death/ld6.sgf
-21 dragon_status B18
-#? [critical (A14|A17|B19) A17]
-22 dragon_status S18
-#? [critical T18 (T18|R18|R19|Q19)]
-23 dragon_status S2
-#? [dead]
-24 dragon_status B2
-#? [critical F1 (F1|D2|D1|B1)]*
-
-loadsgf games/life_and_death/ld7.sgf
-25 dragon_status B18
-#? [dead]*
-26 dragon_status S18
-#? [alive]*
-27 dragon_status S2
-#? [critical (Q2|T2|N2) Q1]*
-28 dragon_status B2
-#? [alive]*
-
-loadsgf games/life_and_death/ld8.sgf
-29 dragon_status B16
-#? [critical C18 (C18|B18|D18)]
-30 dragon_status S18
-#? [critical Q18 (Q18|S19|R19)]
-31 dragon_status S4
-#? [alive]*
-32 dragon_status B2
-#? [critical (C1|A5|A2) (A5|C1|A2)]
-
-loadsgf games/life_and_death/ld9.sgf
-33 dragon_status C16
-#? [dead]
-34 dragon_status R16
-#? [critical (Q19|S18|T18|T16) (T18|S18|Q19)]
-35 dragon_status R3
-#? [critical (T5|S2) (S2|T2|T3)]*
-36 dragon_status C4
-#? [alive]
-
-loadsgf games/life_and_death/ld10.sgf
-37 dragon_status C16
-#? [critical (A17|C19) (A17|C19|A16|A18)]
-38 dragon_status R16
-#? [dead]*
-39 dragon_status R3
-#? [dead]*
-40 dragon_status C4
-#? [critical A5 (B2|A2)]*
-
-loadsgf games/life_and_death/ld11.sgf
-41 dragon_status C16
-#? [critical B19 (B19|A16|B18|C19)]
-42 dragon_status R16
-#? [dead]
-43 dragon_status R3
-#? [critical (R1|S2|T7) S2]
-# B2 lives but allows the opponent to make seki (or ko).
-44 dragon_status C4
-#? [critical D1 (A2|D1|B2)]*
-
-loadsgf games/life_and_death/ld12.sgf
-45 dragon_status C16
-#? [alive]
-46 dragon_status R16
-#? [alive]
-47 dragon_status R3
-#? [dead]
-48 dragon_status C4
-#? [alive]
-
-loadsgf games/life_and_death/ld13.sgf
-49 dragon_status C16
-#? [critical B18 (A18|B18)]
-50 dragon_status R16
-#? [critical (T18|T16) (T18|S18|Q19)]*
-51 dragon_status R3
-#? [critical S1 (R1|S1|T5|T4|T3|S2|S3|T1)]
-52 dragon_status C4
-#? [critical D1 B1]*
-
-loadsgf games/life_and_death/ld14.sgf
-53 dragon_status C16
-#? [critical (C19|B19|B18|A18) (A18|B18)]
-54 dragon_status R16
-#? [critical (T16|O19|T17|T18|S18) T18]
-55 dragon_status R3
-#? [critical (S2|T5|S3|T3|T2|R1|S1) S2]
-56 dragon_status C4
-#? [critical (D1|A5|A2) B1]
-
-loadsgf games/life_and_death/ld15.sgf
-57 dragon_status C16
-#? [critical (A16|A17|A18|B18) A18]*
-58 dragon_status R16
-#? [critical Q19 (T18|S18|Q19|S19)]*
-59 dragon_status R3
-#? [alive]
-60 dragon_status C4
-#? [alive]
-
-loadsgf games/life_and_death/ld16.sgf
-61 dragon_status C16
-#? [critical (B12|D13|D14|A14|A12|B11|C19|B18|A18|B19) (A18|B18|A14|B12)]
-62 dragon_status R16
-#? [alive]
-63 dragon_status R3
-#? [critical (S2|Q2|R2|R1|S1|T5) S2]
-64 dragon_status C4
-#? [alive]
-
-loadsgf games/life_and_death/ld17.sgf
-65 dragon_status B2
-#? [critical A2 A2]
-
-loadsgf games/life_and_death/ld18.sgf 1
-66 dragon_status C9
-#? [alive]
-
-loadsgf games/life_and_death/ld18.sgf
-67 dragon_status C9
-#? [critical A9 A7]
-
-
-loadsgf games/life_and_death/lunches.sgf
-101 dragon_status A17
-#? [dead]
-102 dragon_status A11
-#? [critical (C14|E14|F13|E11) E14]
-103 dragon_status A5
-#? [critical (A1|E7|M2|M1|N2|N1|O2|O1|P1) (A1|E7|M2|A8|C8|F4)]*
-104 dragon_status S1
-#? [critical T6 (T6|T8)]
-105 dragon_status H18
-#? [dead]
-106 dragon_status M7
-#? [critical (O8|L8) O8]
-
-# Report number of nodes visited by the tactical reading
-10000 get_reading_node_counter
-#? [0]&
-
-# Report number of nodes visited by the owl code
-10001 get_owl_node_counter
-#? [0]&
-
-# Report number of nodes visited by the life code
-10002 get_life_node_counter
-#? [0]&
Index: regression/manyfaces.tst
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/manyfaces.tst,v
retrieving revision 1.7
diff -u -r1.7 manyfaces.tst
--- regression/manyfaces.tst    2001/11/07 05:41:30     1.7
+++ regression/manyfaces.tst    2001/11/09 17:13:45
@@ -47,7 +47,7 @@
 
 
 #CATEGORY=OWL_TUNING
-#DESCRIPTION=GnuGo doesn't understand this type of corner position!
+#DESCRIPTION=GNU Go doesn't understand this type of corner position!
 #SEVERITY=10
 #GG often messes up in this type of corner position.
 loadsgf games/mfgg2.sgf 117
Index: regression/nicklas2.tst
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/nicklas2.tst,v
retrieving revision 1.16
diff -u -r1.16 nicklas2.tst
--- regression/nicklas2.tst     2001/11/07 05:41:30     1.16
+++ regression/nicklas2.tst     2001/11/09 17:13:45
@@ -49,11 +49,13 @@
 #? [F1]*
 
 
-#CATEGORY=OWL_TUNING
+#CATEGORY=SEMEAI_MODULE
 #DESCRIPTION=Tough for white to see attacking B, and linking w/ attack stone.
 #SEVERITY=3
 #    The only way to live is to attack a neighbour dragon, e.g. the one
 #    at F8. But does the owl code really do this by default?
+#
+#    No, this is up to the semeai module to resolve. /gf
 #
 loadsgf games/nicklas/nicklas9.sgf 28
 902 dragon_status E9
Index: regression/nicklas4.tst
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/nicklas4.tst,v
retrieving revision 1.5
diff -u -r1.5 nicklas4.tst
--- regression/nicklas4.tst     2001/10/21 19:37:48     1.5
+++ regression/nicklas4.tst     2001/11/09 17:13:45
@@ -26,6 +26,7 @@
 812 gg_genmove black
 #? [J12]
 
+# O9 does leave a ko but is not out of the question. /gf
 loadsgf games/nicklas/nicklas11.sgf 56
 1102 gg_genmove black
 #? [P9]*
@@ -45,9 +46,10 @@
 
 loadsgf games/nicklas/nicklas12.sgf 215
 1215 dragon_status A4
-#? [critical]*
+#? [critical A6 (A1|A6)]*
 
-loadsgf games/nicklas/nicklas15.sgf 185
+# Changed move number from 185 to 186. /gf
+loadsgf games/nicklas/nicklas15.sgf 186
 1501 gg_genmove black
 #? [D17]*
 
Index: regression/nicklas5.tst
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/nicklas5.tst,v
retrieving revision 1.8
diff -u -r1.8 nicklas5.tst
--- regression/nicklas5.tst     2001/11/07 05:41:30     1.8
+++ regression/nicklas5.tst     2001/11/09 17:13:45
@@ -37,10 +37,12 @@
 1204 gg_genmove black
 #? [H15]*
 
+# This is presumably a semeai problem.
 loadsgf games/nicklas/nicklas12.sgf 182
 1211 dragon_status L8
 #? [critical]*
 
+# This is presumably a semeai problem.
 loadsgf games/nicklas/nicklas12.sgf 199
 1212 dragon_status P13
 #? [critical]*
Index: regression/owl.tst
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/owl.tst,v
retrieving revision 1.20
diff -u -r1.20 owl.tst
--- regression/owl.tst  2001/11/07 05:41:30     1.20
+++ regression/owl.tst  2001/11/09 17:13:49
@@ -841,6 +841,10 @@
 229 owl_attack B12
 #? [1 D9]
 
+loadsgf games/owl31.sgf 20
+230 owl_defend G7
+#? [0]
+
 ########### end of tests #####################
 
 # Report number of nodes visited by the tactical reading
Index: regression/reading.tst
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/reading.tst,v
retrieving revision 1.12
diff -u -r1.12 reading.tst
--- regression/reading.tst      2001/10/28 16:01:18     1.12
+++ regression/reading.tst      2001/11/09 17:13:49
@@ -615,6 +615,10 @@
 157 attack R3
 #? [0]
 
+loadsgf games/strategy11.sgf 77
+158 attack H2
+#? [1 G2]*
+
 # Report number of nodes visited by the tactical reading
 10000 get_reading_node_counter
 #? [0]&
Index: regression/strategy.tst
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/strategy.tst,v
retrieving revision 1.13
diff -u -r1.13 strategy.tst
--- regression/strategy.tst     2001/11/07 05:41:30     1.13
+++ regression/strategy.tst     2001/11/09 17:13:49
@@ -289,9 +289,10 @@
 #    the bottom at G2 or (worse but still OK) at J2 is better but
 #    I would class this result as ACCEPTABLE.
 #
-#    3.1.9: Best move here is tough.  GnuGo correctly tries
-#    to stabalize G3 group.
+#    3.1.9: Best move here is tough.  GNO Go correctly tries
+#    to stabilize G3 group.
 #
+# See also reading:158
 loadsgf games/strategy11.sgf 77
 44 gg_genmove black
 #? [G2]*
Index: regression/strategy4.tst
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/strategy4.tst,v
retrieving revision 1.21
diff -u -r1.21 strategy4.tst
--- regression/strategy4.tst    2001/11/07 05:41:30     1.21
+++ regression/strategy4.tst    2001/11/09 17:13:49
@@ -289,7 +289,10 @@
 211 gg_genmove black
 #? [H8]
 
-
+# Pattern LE14 gives an unreasonable value to H3.
+loadsgf games/owl31.sgf 28
+212 gg_genmove white
+#? [G2]
 
 ############ End of Tests #################
 
Index: regression/vie.tst
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/vie.tst,v
retrieving revision 1.5
diff -u -r1.5 vie.tst
--- regression/vie.tst  2001/10/21 19:37:48     1.5
+++ regression/vie.tst  2001/11/09 17:13:49
@@ -45,8 +45,9 @@
 11 owl_defend T8
 #? [1 T7]
 
+# R4 is alive as it stands. Changed the test to defend T11. /gf
 loadsgf golois/Goemate990902-15.sgf
-12 owl_defend R4
+12 owl_defend T11
 #? [1 T7]
 
 loadsgf golois/Goemate990902-3.sgf
@@ -82,7 +83,7 @@
 # B can tenuki. J8 and H9 are miai.
 loadsgf golois/Goemate991106-3.sgf
 20 owl_defend K8
-#? [1 H9]*
+#? [1 (H9|J8|PASS)]*
 
 loadsgf golois/Goemate991106-4.sgf
 21 owl_defend L13
@@ -172,7 +173,7 @@
 
 loadsgf golois/Neurogo97-1.sgf
 42 owl_defend H2
-#? [1 J2]
+#? [1 (J3|G4|J2)]
 
 loadsgf golois/Neurogo97-1.sgf
 43 owl_attack H2
Index: regression/games/owl31.sgf
===================================================================
RCS file: owl31.sgf
diff -N owl31.sgf
--- /dev/null   Sat Apr 14 20:46:23 2001
+++ owl31.sgf   Fri Nov  9 12:13:49 2001
@@ -0,0 +1,12 @@
+(;GM[1]FF[4]
+SZ[9]HA[0]KM[0.5]
+PW[GnuGo (GNU Go 3.1.11)]WR[14k*]
+PB[rubus]BR[30k]
+PC[NNGS]DT[2001-11-07]AP[gnugoclient:2.0]
+RE[W+0.5]
+;B[cc];W[ee];B[gc];W[ec];B[cg];W[ce];B[be];W[eg]C[L:8];B[eb];W[fb]
+C[L:6];B[db];W[fc]C[L:7];B[cf];W[ge];B[cd];W[dh]C[L:8];B[ch];W[de]
+C[L:9];B[dg];W[gb]C[L:10];B[eh];W[fh];B[di];W[fg];B[ef];W[df];B[fi]
+;W[hg];B[gh];W[hh];B[gg];W[ff];B[dd];W[hi];B[gi];W[gf];B[ei];W[ea]
+;B[da];W[fa];B[ed];W[fd];B[dc];W[]C[G7 removed
+final_score: W+0.5])