Re: [gnugo-devel] Unmotivated rebuilding

[bump]

> > 4. Stop sgf_properties.h from being built at all by default. We'd want
> > to keep the make target so that people can rebuild the file if they
> > modify sgf_properties.def. This is quite unlikely though, so it's fine
> > if they have to run the make taret by hand.
> 
> Just adding sgf_properties.h to EXTRA_DIST seems to accomplish 4
> and seems to me to be the best solution.

Unfortunately, that doesn't work.

The attached patch seems to me the simplest solution. It treats
sgf_properties.h just like any other header file, and adds a
fictitious target to make it in case one needs to.

This patch is not in the CVS yet, but it seems OK to me.

Dan

Index: sgf/Makefile.am
===================================================================
RCS file: /cvsroot/gnugo/gnugo/sgf/Makefile.am,v
retrieving revision 1.4
diff -u -r1.4 Makefile.am
--- sgf/Makefile.am     6 Nov 2001 16:36:51 -0000       1.4
+++ sgf/Makefile.am     29 Mar 2002 01:25:41 -0000
@@ -2,16 +2,13 @@
 
 sgfgen_SOURCES = sgfgen.c
 
-EXTRA_DIST = sgf_extras.def sgf_properties.def sgfgen.dsp sgf.dsp sgfgen.dsp
+EXTRA_DIST = sgf_extras.def sgf_properties.def sgfgen.dsp sgf.dsp
 
 noinst_HEADERS = \
        sgftree.h\
        sgf_properties.h
 
-GGBUILTSOURCES = sgf_properties.h
-
 # Remove these files here... they are created locally
-# don't clean up sgfproperties.h
 DISTCLEANFILES = *~
 
 INCLUDES =\
@@ -26,6 +23,8 @@
        sgfnode.c \
        sgftree.c
 
-sgf_properties.h: $(srcdir)/sgf_properties.def $(srcdir)/sgf_extras.def 
sgfgen$(EXEEXT)
+# To rebuild sgf_properties.h in case sgf_properties.def or sgf_extras.def 
+# is changed, 'make sgf_properties'. Normally this is not needed.
+sgf_properties:
        cat $(srcdir)/sgf_properties.def $(srcdir)/sgf_extras.def |\
                ./sgfgen > sgf_properties.h
Index: sgf/Makefile.in
===================================================================
RCS file: /cvsroot/gnugo/gnugo/sgf/Makefile.in,v
retrieving revision 1.25
diff -u -r1.25 Makefile.in
--- sgf/Makefile.in     3 Jan 2002 04:58:22 -0000       1.25
+++ sgf/Makefile.in     29 Mar 2002 01:25:41 -0000
@@ -82,17 +82,14 @@
 
 sgfgen_SOURCES = sgfgen.c
 
-EXTRA_DIST = sgf_extras.def sgf_properties.def sgfgen.dsp sgf.dsp sgfgen.dsp
+EXTRA_DIST = sgf_extras.def sgf_properties.def sgfgen.dsp sgf.dsp
 
 noinst_HEADERS = \
        sgftree.h\
        sgf_properties.h
 
 
-GGBUILTSOURCES = sgf_properties.h
-
 # Remove these files here... they are created locally
-# don't clean up sgfproperties.h
 DISTCLEANFILES = *~
 
 INCLUDES = \
@@ -335,7 +332,9 @@
        uninstall-am uninstall-info-am
 
 
-sgf_properties.h: $(srcdir)/sgf_properties.def $(srcdir)/sgf_extras.def 
sgfgen$(EXEEXT)
+# To rebuild sgf_properties.h in case sgf_properties.def or sgf_extras.def 
+# is changed, 'make sgf_properties'. Normally this is not needed.
+sgf_properties:
        cat $(srcdir)/sgf_properties.def $(srcdir)/sgf_extras.def |\
                ./sgfgen > sgf_properties.h
 # Tell versions [3.59,3.63) of GNU make to not export all variables.