Re: [gnugo-devel] komaster

[Paul Pogonyshev]

Arend wrote:
> 
> This patch makes komaster and kom_pos private variables in board.c. This
> means that all the recursive reading functions don't have to keep track
> of komaster states anymore, this is done automatically when they call
> komaster_trymove() or trymove(). They are kept track of with the the
> PUSH_VALUE() machinery. So this gets rid of all the "int new_komaster,
> new_kom_pos" etc. in reading.c etc. Altogether, it removes some 130 lines.

That's always good to hear.

> There is an implied change in behaviour. E.g. when a black gets komaster
> in owl reading, and a reading helper function is called, then this
> reading will be done under the same komaster state. I think this change
> is beneficial, and while the breakage is bad, I think close analysis shows
> that it is in fact useful. nngs4:270 is the only problem.

Agreed.  I think I pondered this problem some day, but I have never really
understood this komaster stuff behind that point it allowed to analyze kos
well enough.

And, it's pleasant to note that GNU Go development is getting more active
(thanks to Arend mostly ;).

Paul