[gnugo-devel] test results by "!"

[Arend Bayer]

As we all know, test with result [!...] are bad. This patch revises all such
test in 13x13.tst and 13x13b.tst, most of them by using restricted_genmove,
some by removing when I didn't see much point in following up with the
original intention of the testcase.

Arend

Remaing offenders:
testsuite:number of "[!" result

blunder.tst:16
nicklas1.tst:34
nngs.tst:48
nngs1.tst:11
nngs2.tst:12
nngs3.tst:32
nngs4.tst:11
strategy.tst:13
strategy2.tst:10
strategy4.tst:12
trevor.tst:22
trevora.tst:12
trevorb.tst:35
trevorc.tst:56
trevord.tst:29

Index: regression/13x13.tst
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/13x13.tst,v
retrieving revision 1.62
diff -u -p -r1.62 13x13.tst
--- regression/13x13.tst        20 Jan 2005 19:04:34 -0000      1.62
+++ regression/13x13.tst        27 Sep 2005 03:47:46 -0000
@@ -23,8 +23,8 @@ loadsgf games/mertin13x13/goliath-gnugo1
 #? [E9|E10]
 
 loadsgf games/mertin13x13/goliath-gnugo1.B+11.sgf 58
-3 reg_genmove white
-#? [!E2]
+3 restricted_genmove white E2 E5
+#? [E5]
 
 #CATEGORY=OWL_TUNING
 # Of course it is nice if you can get away with J11 as GNU Go did in the
@@ -51,8 +51,8 @@ loadsgf games/mertin13x13/goliath-gnugo3
 
 #CATEGORY=ENDGAME_TUNING
 loadsgf games/mertin13x13/goliath-gnugo3.W+0.sgf 54
-8 reg_genmove white
-#? [!K6]
+8 restricted_genmove white K6 K7 J8 H8
+#? [J8]
 
 #CATEGORY=BLUNDER
 loadsgf games/mertin13x13/goliath-gnugo3.W+0.sgf 72
@@ -74,16 +74,16 @@ loadsgf games/mertin13x13/gointellect-gn
 12 reg_genmove white
 #? [G7|F7|G8]
 
-#CATEGORY=STRATEGY
-loadsgf games/mertin13x13/gointellect-gnugo2.W+8.sgf 22
-13 reg_genmove white
-#? [!G7]*
+##CATEGORY=STRATEGY
+#loadsgf games/mertin13x13/gointellect-gnugo2.W+8.sgf 22
+#13 reg_genmove white
+##? [!G7]*
 
 #CATEGORY=STRATEGY
 # New failure (comparing 3.1.15 with 3.0.0)
 loadsgf games/mertin13x13/gointellect-gnugo2.W+8.sgf 28
 14 reg_genmove white
-#? [!C11]
+#? [A10|E8|E6|H6]
 
 #CATEGORY=STRATEGY
 # New failure (comparing 3.1.15 and 3.0.0)
@@ -109,8 +109,8 @@ loadsgf games/mertin13x13/gointellect-gn
 #? [0]
 
 loadsgf games/mertin13x13/gointellect-gnugo3.B+1.sgf 48
-19 reg_genmove white
-#? [!N3]
+19 restricted_genmove white M8 N3
+#? [M8]
 
 #CATEGORY=ENDGAME_TUNING
 loadsgf games/mertin13x13/gointellect-gnugo3.B+1.sgf 60
@@ -161,7 +161,7 @@ loadsgf games/mertin13x13/katsunari-gnug
 
 loadsgf games/mertin13x13/katsunari-gnugo1.W+45.sgf 32
 30 reg_genmove white
-#? [!C11]
+#? [B7|J13|E2|J6]
 
 loadsgf games/mertin13x13/katsunari-gnugo1.W+45.sgf 64
 31 reg_genmove white
@@ -208,9 +208,9 @@ loadsgf games/mertin13x13/katsunari-gnug
 40 reg_genmove white
 #? [K13]*
 
-loadsgf games/mertin13x13/katsunari-gnugo2.W+4.sgf 60
-41 reg_genmove white
-#? [!C8]
+#loadsgf games/mertin13x13/katsunari-gnugo2.W+4.sgf 60
+#41 reg_genmove white
+##? [!C8]
 
 #CATEGORY=SEMEAI
 loadsgf games/mertin13x13/katsunari-gnugo2.W+4.sgf 126
@@ -250,8 +250,8 @@ loadsgf games/mertin13x13/gnugo-goliath1
 
 #CATEGORY=FUSEKI_STRATEGY
 loadsgf games/mertin13x13/gnugo-goliath2.W+38.sgf 7
-47 reg_genmove black
-#? [!G11]
+47 restricted_genmove black K8 K9 G11
+#? [K8|K9]
 
 loadsgf games/mertin13x13/gnugo-goliath2.W+38.sgf 11
 48 reg_genmove black
@@ -269,8 +269,8 @@ loadsgf games/mertin13x13/gnugo-goliath2
 # Here N11 is generated as an "additional attack/defense move", although
 # the black dragon is still dead after black connects at N11.
 loadsgf games/mertin13x13/gnugo-goliath2.W+38.sgf 27
-50 reg_genmove black
-#? [!N11|M8]
+50 owl_defend L10
+#? [0]
 
 loadsgf games/mertin13x13/gnugo-goliath2.W+38.sgf 33
 51 reg_genmove black
@@ -315,10 +315,10 @@ loadsgf games/mertin13x13/gnugo-goliath3
 58 owl_attack J2
 #? [0]
 
-# New failure (comparing 3.1.15 with 3.0.0)
+# Moves like C8 are severly undervalued by GNU Go. /ab
 loadsgf games/mertin13x13/gnugo-katsunari1.B+21.sgf 13
-59 reg_genmove black
-#? [!J12]
+59 restricted_genmove black J11 C8
+#? [C8]
 
 loadsgf games/mertin13x13/gnugo-katsunari1.B+21.sgf 15
 60 reg_genmove black
@@ -366,8 +366,8 @@ loadsgf games/mertin13x13/gnugo-katsunar
 # There is s.th. odd in the influence function in comparison between
 # D4 and D5.
 loadsgf games/mertin13x13/gnugo-katsunari2.B+66.sgf 89
-69 reg_genmove black
-#? [!D4]
+69 restricted_genmove black D4 D5
+#? [D5]
 
 #CATEGORY=FUSEKI_STRATEGY
 # I think that securing the corner is larger.
@@ -397,10 +397,11 @@ loadsgf games/mertin13x13/gnugo-gointell
 74 reg_genmove black
 #? [G10]
 
+# D11 is a no-no. /ab
 #CATEGORY=TERRITORIAL_EVALUATION
 loadsgf games/mertin13x13/gnugo-gointellect2.W+2.sgf 13
-75 reg_genmove black
-#? [!D11]
+75 restricted_genmove black D11 E12
+#? [E12]
 
 #CATEGORY=TERRITORIAL_EVALUATION
 loadsgf games/mertin13x13/gnugo-gointellect2.W+2.sgf 17
@@ -463,8 +464,8 @@ loadsgf games/mertin13x13/gnugo-gointell
 #CATEGORY=BLUNDER
 # New failure (comparing 3.1.15 with 3.0.0)
 loadsgf games/mertin13x13/gnugo-gointellect3.W+37.sgf 69
-88 reg_genmove black
-#? [!A9]
+88 restricted_genmove black A9 D6
+#? [D6]
 
 #CATEGORY=OWL_TUNING
 # New failure (comparing 3.1.15 with 3.0.0)
Index: regression/13x13b.tst
===================================================================
RCS file: /cvsroot/gnugo/gnugo/regression/13x13b.tst,v
retrieving revision 1.13
diff -u -p -r1.13 13x13b.tst
--- regression/13x13b.tst       31 Dec 2003 07:05:11 -0000      1.13
+++ regression/13x13b.tst       27 Sep 2005 03:47:46 -0000
@@ -79,7 +79,7 @@ loadsgf games/mertin13x13/GNDA3.sgf 61
 
 loadsgf games/mertin13x13/GAGN1.sgf 12
 2 reg_genmove white
-#? [!B12]
+#? [C12|G10|G12]
 
 # N5 is locally worse than M5.
 loadsgf games/mertin13x13/GAGN1.sgf 28
@@ -113,13 +113,13 @@ loadsgf games/mertin13x13/GNGA3.sgf 81
 
 # Most other moves are better than the game move at C6.
 loadsgf games/mertin13x13/GHGN1.sgf 26
-9 reg_genmove white
-#? [!C6]
+9 owl_attack D7
+#? [0]
 
 # Most other moves are better than the game move at M6.
 loadsgf games/mertin13x13/GHGN2.sgf 48
-10 reg_genmove white
-#? [!M6]
+10 restricted_genmove white M4 L6 M6
+#? [M4|L6]
 
 # L6 urgent.
 loadsgf games/mertin13x13/GHGN2.sgf 52
@@ -128,13 +128,13 @@ loadsgf games/mertin13x13/GHGN2.sgf 52
 
 # J5 not joseki.
 loadsgf games/mertin13x13/GHGN3.sgf 8
-12 reg_genmove white
-#? [!J5]
+12 restricted_genmove white J5 J6
+#? [J6]
 
 # M13 is a very odd move.
 loadsgf games/mertin13x13/GHGN3.sgf 38
-13 reg_genmove white
-#? [!M13]
+13 restricted_genmove white M11 M12 M13 K12
+#? [K12]
 
 # J9 is huge.
 loadsgf games/mertin13x13/GNGH2.sgf 23
@@ -173,8 +173,8 @@ loadsgf games/mertin13x13/GIGN3.sgf 92
 
 # J13 fails right out.
 loadsgf games/mertin13x13/GIGN3.sgf 94
-21 reg_genmove white
-#? [!J13]
+21 restricted_genmove white K11 J13
+#? [K11]
 
 # A6 bad shape.
 loadsgf games/mertin13x13/GIGN3.sgf 100
@@ -206,10 +206,11 @@ loadsgf games/mertin13x13/GMGN2.sgf 92
 27 reg_genmove white
 #? [C4]
 
-# H9 can be cut off.
-loadsgf games/mertin13x13/GMGN3.sgf 30
-28 reg_genmove white
-#? [!H9]
+# Taken out -- H9 seems reasonable nevertheless. /ab
+## H9 can be cut off.
+#loadsgf games/mertin13x13/GMGN3.sgf 30
+#28 reg_genmove white
+##? [!H9]
 
 # Must connect at F3.
 loadsgf games/mertin13x13/GNGM3.sgf 11
@@ -237,12 +238,13 @@ loadsgf games/mertin13x13/GNGP5.sgf 73
 # E5 is just cut off and captured.
 loadsgf games/mertin13x13/GXGN2.sgf 48
 34 reg_genmove white
-#? [!E5]
+#? [E8|F9|F8|D7]
 
+# Breakin problem.
 # D10 captures on too small scale.
 loadsgf games/mertin13x13/GXGN2.sgf 52
 35 reg_genmove white
-#? [!D10]
+#? [D7|E8|F9]
 
 # Low enclosure better.
 loadsgf games/mertin13x13/GXGN3.sgf 12