[GNUnet-SVN] r9350 - in gnunet: . src/datacache src/datastore src/fs src/hostlist src/util

[gnunet]

Author: grothoff
Date: 2009-10-30 12:58:25 -0600 (Fri, 30 Oct 2009)
New Revision: 9350

Modified:
   gnunet/BUGS
   gnunet/src/datacache/datacache.c
   gnunet/src/datastore/test_datastore_api.c
   gnunet/src/datastore/test_datastore_api_management.c
   gnunet/src/fs/test_fs_download.c
   gnunet/src/fs/test_fs_list_indexed.c
   gnunet/src/fs/test_fs_namespace.c
   gnunet/src/fs/test_fs_publish.c
   gnunet/src/fs/test_fs_start_stop.c
   gnunet/src/fs/test_fs_unindex.c
   gnunet/src/hostlist/test_gnunet_daemon_hostlist.c
   gnunet/src/util/container_heap.c
Log:
bugfixes

Modified: gnunet/BUGS
===================================================================
--- gnunet/BUGS 2009-10-30 18:35:06 UTC (rev 9349)
+++ gnunet/BUGS 2009-10-30 18:58:25 UTC (rev 9350)
@@ -82,6 +82,22 @@
     ==28393==    by 0x524473E: GNUNET_NETWORK_socket_create_from_accept 
(network.c:323)
     (rest of trace identical)
 
+  - [./transport/gnunet-service-transport.c:173]: (style) struct or union 
member 'TransportPlugin::rebuild' is never used
+  - [./transport/plugin_transport_tcp.c:391]: (style) struct or union member 
'Plugin::address_update_task' is never used
+
+* FS:
+  - [./fs/gnunet-service-fs.c:208]: (style) struct or union member 
'LocalGetContext::results_bf_size' is never used
+  - [./fs/gnunet-service-fs.c:501]: (style) struct or union member 
'PendingRequest::used_pids_size' is never used
+  - [./fs/gnunet-service-fs.c:654]: (style) struct or union member 
'ConnectedPeer::last_client_replies' is never used
+  - [./fs/gnunet-service-fs.c:669]: (style) struct or union member 
'ConnectedPeer::avg_delay' is never used
+  - [./fs/gnunet-service-fs.c:675]: (style) struct or union member 
'ConnectedPeer::avg_priority' is never used
+  - [./fs/gnunet-service-fs.c:688]: (style) struct or union member 
'ConnectedPeer::pending_requests' is never used
+  - [./fs/gnunet-service-fs.c:694]: (style) struct or union member 
'ConnectedPeer::last_p2p_replies_woff' is never used
+  - [./fs/gnunet-service-fs.c:700]: (style) struct or union member 
'ConnectedPeer::last_client_replies_woff' is never used
+
+* TOPOLOGY:
+  - [./topology/gnunet-daemon-topology.c:94]: (style) struct or union member 
'PeerList::last_hello_sent' is never used
+
 * DATASTORE:
   - mysql backend
   - postgres backend
@@ -100,6 +116,9 @@
     to signal on PONG and have topology hook directly into transport to
     kill plaintext connections before they have a chance to become encrypted
     (may require minor hack in transport API)
+  - [./core/gnunet-service-core.c:469]: (style) struct or union member 
'Neighbour::message_queue_size' is never used
+  - [./core/test_core_api_start_only.c:50]: (style) struct or union member 
'PeerContext::id' is never used
+
 * PEERINFO:
   - have gnunet-peerinfo print actual host addresses again
   - add option to gnunet-peerinfo to modify trust value

Modified: gnunet/src/datacache/datacache.c
===================================================================
--- gnunet/src/datacache/datacache.c    2009-10-30 18:35:06 UTC (rev 9349)
+++ gnunet/src/datacache/datacache.c    2009-10-30 18:58:25 UTC (rev 9350)
@@ -35,11 +35,6 @@
 {
 
   /**
-   * Our datastore plugin (NULL if not available).
-   */
-  struct DatastorePlugin *plugin;
-  
-  /**
    * Bloomfilter to quickly tell if we don't have the content.
    */
   struct GNUNET_CONTAINER_BloomFilter *filter;

Modified: gnunet/src/datastore/test_datastore_api.c
===================================================================
--- gnunet/src/datastore/test_datastore_api.c   2009-10-30 18:35:06 UTC (rev 
9349)
+++ gnunet/src/datastore/test_datastore_api.c   2009-10-30 18:58:25 UTC (rev 
9350)
@@ -118,7 +118,6 @@
   GNUNET_HashCode key;
   int i;
   int rid;
-  int *iptr;
   struct GNUNET_SCHEDULER_Handle *sched;
   const struct GNUNET_CONFIGURATION_Handle *cfg;
   void *data;

Modified: gnunet/src/datastore/test_datastore_api_management.c
===================================================================
--- gnunet/src/datastore/test_datastore_api_management.c        2009-10-30 
18:35:06 UTC (rev 9349)
+++ gnunet/src/datastore/test_datastore_api_management.c        2009-10-30 
18:58:25 UTC (rev 9350)
@@ -111,7 +111,6 @@
   struct GNUNET_SCHEDULER_Handle *sched;
   const struct GNUNET_CONFIGURATION_Handle *cfg;
   void *data;
-  size_t size;
   enum RunPhase phase;
 };
 

Modified: gnunet/src/fs/test_fs_download.c
===================================================================
--- gnunet/src/fs/test_fs_download.c    2009-10-30 18:35:06 UTC (rev 9349)
+++ gnunet/src/fs/test_fs_download.c    2009-10-30 18:58:25 UTC (rev 9350)
@@ -51,7 +51,6 @@
 struct PeerContext
 {
   struct GNUNET_CONFIGURATION_Handle *cfg;
-  struct GNUNET_PeerIdentity id;   
 #if START_ARM
   pid_t arm_pid;
 #endif

Modified: gnunet/src/fs/test_fs_list_indexed.c
===================================================================
--- gnunet/src/fs/test_fs_list_indexed.c        2009-10-30 18:35:06 UTC (rev 
9349)
+++ gnunet/src/fs/test_fs_list_indexed.c        2009-10-30 18:58:25 UTC (rev 
9350)
@@ -55,7 +55,6 @@
 struct PeerContext
 {
   struct GNUNET_CONFIGURATION_Handle *cfg;
-  struct GNUNET_PeerIdentity id;   
 #if START_ARM
   pid_t arm_pid;
 #endif

Modified: gnunet/src/fs/test_fs_namespace.c
===================================================================
--- gnunet/src/fs/test_fs_namespace.c   2009-10-30 18:35:06 UTC (rev 9349)
+++ gnunet/src/fs/test_fs_namespace.c   2009-10-30 18:58:25 UTC (rev 9350)
@@ -41,7 +41,6 @@
 struct PeerContext
 {
   struct GNUNET_CONFIGURATION_Handle *cfg;
-  struct GNUNET_PeerIdentity id;   
 #if START_ARM
   pid_t arm_pid;
 #endif

Modified: gnunet/src/fs/test_fs_publish.c
===================================================================
--- gnunet/src/fs/test_fs_publish.c     2009-10-30 18:35:06 UTC (rev 9349)
+++ gnunet/src/fs/test_fs_publish.c     2009-10-30 18:58:25 UTC (rev 9350)
@@ -52,7 +52,6 @@
 struct PeerContext
 {
   struct GNUNET_CONFIGURATION_Handle *cfg;
-  struct GNUNET_PeerIdentity id;   
 #if START_ARM
   pid_t arm_pid;
 #endif

Modified: gnunet/src/fs/test_fs_start_stop.c
===================================================================
--- gnunet/src/fs/test_fs_start_stop.c  2009-10-30 18:35:06 UTC (rev 9349)
+++ gnunet/src/fs/test_fs_start_stop.c  2009-10-30 18:58:25 UTC (rev 9350)
@@ -38,7 +38,6 @@
 struct PeerContext
 {
   struct GNUNET_CONFIGURATION_Handle *cfg;
-  struct GNUNET_PeerIdentity id;   
 #if START_ARM
   pid_t arm_pid;
 #endif

Modified: gnunet/src/fs/test_fs_unindex.c
===================================================================
--- gnunet/src/fs/test_fs_unindex.c     2009-10-30 18:35:06 UTC (rev 9349)
+++ gnunet/src/fs/test_fs_unindex.c     2009-10-30 18:58:25 UTC (rev 9350)
@@ -51,7 +51,6 @@
 struct PeerContext
 {
   struct GNUNET_CONFIGURATION_Handle *cfg;
-  struct GNUNET_PeerIdentity id;   
 #if START_ARM
   pid_t arm_pid;
 #endif

Modified: gnunet/src/hostlist/test_gnunet_daemon_hostlist.c
===================================================================
--- gnunet/src/hostlist/test_gnunet_daemon_hostlist.c   2009-10-30 18:35:06 UTC 
(rev 9349)
+++ gnunet/src/hostlist/test_gnunet_daemon_hostlist.c   2009-10-30 18:58:25 UTC 
(rev 9350)
@@ -44,8 +44,6 @@
 struct PeerContext
 {
   struct GNUNET_CONFIGURATION_Handle *cfg;
-  struct GNUNET_CORE_Handle *ch;
-  struct GNUNET_PeerIdentity id; 
   struct GNUNET_TRANSPORT_Handle *th;
   struct GNUNET_MessageHeader *hello;
 #if START_ARM

Modified: gnunet/src/util/container_heap.c
===================================================================
--- gnunet/src/util/container_heap.c    2009-10-30 18:35:06 UTC (rev 9349)
+++ gnunet/src/util/container_heap.c    2009-10-30 18:58:25 UTC (rev 9350)
@@ -28,19 +28,7 @@
 #include "gnunet_protocols.h"
 #include "gnunet_util_lib.h"
 
-/*
- * Struct that is stored in hashmap, pointers to
- * locations in min_heap and max_heap.
- */
-struct GNUNET_CONTAINER_heap_info
-{
-  struct GNUNET_CONTAINER_heap_node *min_loc;
-
-  struct GNUNET_CONTAINER_heap_node *max_loc;
-
-};
-
-/*
+/**
  * Generic heap node structure, contains pointer to parent
  * left child, right child, and actual neighbor.
  */
@@ -211,7 +199,7 @@
 getPos (struct GNUNET_CONTAINER_Heap *root, unsigned int pos)
 {
   struct GNUNET_CONTAINER_heap_node *ret;
-  int i;
+  unsigned int i;
 
   ret = NULL;
   if (pos > root->size)