[GNUnet-SVN] r13709 - gnunet/src/vpn

[gnunet]

Author: toelke
Date: 2010-11-17 09:55:34 +0100 (Wed, 17 Nov 2010)
New Revision: 13709

Modified:
   gnunet/src/vpn/gnunet-daemon-vpn.c
Log:
Fix memory-leak (and superfluous copy)

Modified: gnunet/src/vpn/gnunet-daemon-vpn.c
===================================================================
--- gnunet/src/vpn/gnunet-daemon-vpn.c  2010-11-17 08:55:33 UTC (rev 13708)
+++ gnunet/src/vpn/gnunet-daemon-vpn.c  2010-11-17 08:55:34 UTC (rev 13709)
@@ -422,11 +422,14 @@
            break;
          case 0x3a:
            /* ICMPv6 */
-           pkt6_icmp = GNUNET_malloc(ntohs(pkt6->shdr.size));
-           memcpy(pkt6_icmp, pkt6, ntohs(pkt6->shdr.size));
+           pkt6_icmp = (struct ip6_icmp*)pkt6;
            /* If this packet is an icmp-echo-request and a mapping exists, 
answer */
            if (pkt6_icmp->icmp_hdr.type == 0x80 && 
address_mapping_exists(pkt6->ip6_hdr.sadr))
+             {
+               pkt6_icmp = GNUNET_malloc(ntohs(pkt6->shdr.size));
+               memcpy(pkt6_icmp, pkt6, ntohs(pkt6->shdr.size));
                GNUNET_SCHEDULER_add_now(&send_icmp_response, pkt6_icmp);
+             }
            break;
          }
       }