[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[GNUnet-SVN] r27104 - gnunet/src/testbed
From: |
gnunet |
Subject: |
[GNUnet-SVN] r27104 - gnunet/src/testbed |
Date: |
Mon, 13 May 2013 16:03:33 +0200 |
Author: harsha
Date: 2013-05-13 16:03:32 +0200 (Mon, 13 May 2013)
New Revision: 27104
Modified:
gnunet/src/testbed/gnunet-service-testbed.c
gnunet/src/testbed/gnunet-service-testbed.h
gnunet/src/testbed/gnunet-service-testbed_links.c
gnunet/src/testbed/testbed.h
gnunet/src/testbed/testbed_api.c
gnunet/src/testbed/testbed_api_hosts.c
Log:
- remove hostname/ip address from INIT message. They will be determined by the
controller automatically
Modified: gnunet/src/testbed/gnunet-service-testbed.c
===================================================================
--- gnunet/src/testbed/gnunet-service-testbed.c 2013-05-13 12:55:20 UTC (rev
27103)
+++ gnunet/src/testbed/gnunet-service-testbed.c 2013-05-13 14:03:32 UTC (rev
27104)
@@ -474,6 +474,48 @@
/**
+ * Callback function invoked for each interface found.
+ *
+ * @param cls NULL
+ * @param name name of the interface (can be NULL for unknown)
+ * @param isDefault is this presumably the default interface
+ * @param addr address of this interface (can be NULL for unknown or
unassigned)
+ * @param broadcast_addr the broadcast address (can be NULL for unknown or
unassigned)
+ * @param netmask the network mask (can be NULL for unknown or unassigned))
+ * @param addrlen length of the address
+ * @return GNUNET_OK to continue iteration, GNUNET_SYSERR to abort
+ */
+static int
+addr_proc (void *cls, const char *name, int isDefault,
+ const struct sockaddr *addr,
+ const struct sockaddr *broadcast_addr,
+ const struct sockaddr *netmask, socklen_t addrlen)
+{
+ struct Context *ctx = cls;
+ const struct sockaddr_in *in_addr;
+ char *ipaddr;
+ char *tmp;
+
+ if (sizeof (struct sockaddr_in) != addrlen)
+ return GNUNET_OK;
+ in_addr = (const struct sockaddr_in *) addr;
+ if (NULL == (ipaddr = inet_ntoa (in_addr->sin_addr)))
+ return GNUNET_OK;
+ if (NULL == ctx->master_ips)
+ {
+ ctx->master_ips = GNUNET_strdup (ipaddr);
+ return GNUNET_OK;
+ }
+ tmp = NULL;
+ (void) GNUNET_asprintf (&tmp, "%s; %s", ctx->master_ips, ipaddr);
+ GNUNET_free (ctx->master_ips);
+ ctx->master_ips = tmp;
+ return GNUNET_OK;
+}
+
+
+
+/**
* Message handler for GNUNET_MESSAGE_TYPE_TESTBED_INIT messages
*
* @param cls NULL
@@ -486,11 +528,11 @@
{
const struct GNUNET_TESTBED_InitMessage *msg;
struct GNUNET_TESTBED_Host *host;
- const char *controller_hostname;
char *ss_str;
struct GNUNET_TESTING_SharedService *ss;
+ char *hostname;
unsigned int cnt;
- uint16_t msize;
+ unsigned int len;
if (NULL != GST_context)
{
@@ -499,21 +541,14 @@
return;
}
msg = (const struct GNUNET_TESTBED_InitMessage *) message;
- msize = ntohs (message->size);
- if (msize <= sizeof (struct GNUNET_TESTBED_InitMessage))
+ len = GNUNET_OS_get_hostname_max_length ();
+ hostname = GNUNET_malloc (len);
+ if (0 != gethostname (hostname, len))
{
- GNUNET_break (0);
+ GNUNET_log_strerror (GNUNET_ERROR_TYPE_WARNING, "gethostname");
GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
return;
}
- msize -= sizeof (struct GNUNET_TESTBED_InitMessage);
- controller_hostname = (const char *) &msg[1];
- if ('\0' != controller_hostname[msize - 1])
- {
- GNUNET_break (0);
- GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
- return;
- }
ss_str = NULL;
ss = NULL;
if (GNUNET_OK == GNUNET_CONFIGURATION_get_value_string (our_config,
"TESTBED",
@@ -528,10 +563,18 @@
GNUNET_SERVER_client_keep (client);
GST_context->client = client;
GST_context->host_id = ntohl (msg->host_id);
- GST_context->master_ip = GNUNET_strdup (controller_hostname);
- LOG_DEBUG ("Our IP: %s\n", GST_context->master_ip);
+ GNUNET_OS_network_interfaces_list (&addr_proc, GST_context);
+ if (NULL == GST_context->master_ips)
+ {
+ LOG (GNUNET_ERROR_TYPE_ERROR,
+ "Testbed needs networking, but no network interfaces are found on
this host. Exiting\n");
+ GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);
+ GNUNET_SCHEDULER_shutdown ();
+ return;
+ }
+ LOG_DEBUG ("Our IP addresses: %s\n", GST_context->master_ips);
GST_context->system =
- GNUNET_TESTING_system_create ("testbed", GST_context->master_ip,
+ GNUNET_TESTING_system_create ("testbed", GST_context->master_ips,
hostname, ss);
if (NULL != ss)
{
@@ -543,10 +586,9 @@
GNUNET_free (ss);
ss = NULL;
}
- host =
- GNUNET_TESTBED_host_create_with_id (GST_context->host_id,
- GST_context->master_ip, NULL,
- our_config, 0);
+
+ host = GNUNET_TESTBED_host_create_with_id (GST_context->host_id, hostname,
+ NULL, our_config, 0);
host_list_add (host);
LOG_DEBUG ("Created master context with host ID: %u\n",
GST_context->host_id);
GNUNET_SERVER_receive_done (client, GNUNET_OK);
@@ -808,7 +850,7 @@
GNUNET_free_non_null (GST_host_list);
if (NULL != GST_context)
{
- GNUNET_free_non_null (GST_context->master_ip);
+ GNUNET_free_non_null (GST_context->master_ips);
if (NULL != GST_context->system)
GNUNET_TESTING_system_destroy (GST_context->system, GNUNET_YES);
GNUNET_SERVER_client_drop (GST_context->client);
@@ -870,7 +912,8 @@
const struct GNUNET_CONFIGURATION_Handle *cfg)
{
static const struct GNUNET_SERVER_MessageHandler message_handlers[] = {
- {&handle_init, NULL, GNUNET_MESSAGE_TYPE_TESTBED_INIT, 0},
+ {&handle_init, NULL, GNUNET_MESSAGE_TYPE_TESTBED_INIT,
+ sizeof (struct GNUNET_TESTBED_InitMessage)},
{&handle_add_host, NULL, GNUNET_MESSAGE_TYPE_TESTBED_ADD_HOST, 0},
{&GST_handle_link_controllers, NULL,
GNUNET_MESSAGE_TYPE_TESTBED_LINK_CONTROLLERS,
Modified: gnunet/src/testbed/gnunet-service-testbed.h
===================================================================
--- gnunet/src/testbed/gnunet-service-testbed.h 2013-05-13 12:55:20 UTC (rev
27103)
+++ gnunet/src/testbed/gnunet-service-testbed.h 2013-05-13 14:03:32 UTC (rev
27104)
@@ -260,7 +260,7 @@
/**
* The network address of the master controller
*/
- char *master_ip;
+ char *master_ips;
/**
* The TESTING system handle for starting peers locally
Modified: gnunet/src/testbed/gnunet-service-testbed_links.c
===================================================================
--- gnunet/src/testbed/gnunet-service-testbed_links.c 2013-05-13 12:55:20 UTC
(rev 27103)
+++ gnunet/src/testbed/gnunet-service-testbed_links.c 2013-05-13 14:03:32 UTC
(rev 27104)
@@ -1248,7 +1248,7 @@
lcc->client = client;
slave->lcc = lcc;
slave->controller_proc =
- GNUNET_TESTBED_controller_start (GST_context->master_ip,
+ GNUNET_TESTBED_controller_start (GST_context->master_ips,
GST_host_list[slave->host_id],
&slave_status_cb, slave);
new_route = GNUNET_malloc (sizeof (struct Route));
Modified: gnunet/src/testbed/testbed.h
===================================================================
--- gnunet/src/testbed/testbed.h 2013-05-13 12:55:20 UTC (rev 27103)
+++ gnunet/src/testbed/testbed.h 2013-05-13 14:03:32 UTC (rev 27104)
@@ -54,8 +54,6 @@
* is interested in. In NBO.
*/
uint64_t event_mask GNUNET_PACKED;
-
- /* Followed by 0-terminated hostname of the controller */
};
Modified: gnunet/src/testbed/testbed_api.c
===================================================================
--- gnunet/src/testbed/testbed_api.c 2013-05-13 12:55:20 UTC (rev 27103)
+++ gnunet/src/testbed/testbed_api.c 2013-05-13 14:03:32 UTC (rev 27104)
@@ -1436,10 +1436,9 @@
GNUNET_TESTBED_ControllerCallback cc,
void *cc_cls)
{
- struct GNUNET_TESTBED_Controller *controller;
+ struct GNUNET_TESTBED_Controller *c;
struct GNUNET_TESTBED_InitMessage *msg;
const struct GNUNET_CONFIGURATION_Handle *cfg;
- const char *controller_hostname;
unsigned long long max_parallel_operations;
unsigned long long max_parallel_service_connections;
unsigned long long max_parallel_topology_config_operations;
@@ -1469,44 +1468,35 @@
GNUNET_break (0);
return NULL;
}
- controller = GNUNET_malloc (sizeof (struct GNUNET_TESTBED_Controller));
- controller->cc = cc;
- controller->cc_cls = cc_cls;
- controller->event_mask = event_mask;
- controller->cfg = GNUNET_CONFIGURATION_dup (cfg);
- controller->client = GNUNET_CLIENT_connect ("testbed", controller->cfg);
- if (NULL == controller->client)
+ c = GNUNET_malloc (sizeof (struct GNUNET_TESTBED_Controller));
+ c->cc = cc;
+ c->cc_cls = cc_cls;
+ c->event_mask = event_mask;
+ c->cfg = GNUNET_CONFIGURATION_dup (cfg);
+ c->client = GNUNET_CLIENT_connect ("testbed", c->cfg);
+ if (NULL == c->client)
{
- GNUNET_TESTBED_controller_disconnect (controller);
+ GNUNET_TESTBED_controller_disconnect (c);
return NULL;
}
- GNUNET_TESTBED_mark_host_registered_at_ (host, controller);
- controller->host = host;
- controller->opq_parallel_operations =
+ GNUNET_TESTBED_mark_host_registered_at_ (host, c);
+ c->host = host;
+ c->opq_parallel_operations =
GNUNET_TESTBED_operation_queue_create_ ((unsigned int)
max_parallel_operations);
- controller->opq_parallel_service_connections =
+ c->opq_parallel_service_connections =
GNUNET_TESTBED_operation_queue_create_ ((unsigned int)
max_parallel_service_connections);
- controller->opq_parallel_topology_config_operations =
+ c->opq_parallel_topology_config_operations =
GNUNET_TESTBED_operation_queue_create_ ((unsigned int)
max_parallel_topology_config_operations);
- controller_hostname = GNUNET_TESTBED_host_get_hostname (host);
- if (NULL == controller_hostname)
- controller_hostname = "127.0.0.1";
- msg =
- GNUNET_malloc (sizeof (struct GNUNET_TESTBED_InitMessage) +
- strlen (controller_hostname) + 1);
+ msg = GNUNET_malloc (sizeof (struct GNUNET_TESTBED_InitMessage));
msg->header.type = htons (GNUNET_MESSAGE_TYPE_TESTBED_INIT);
- msg->header.size =
- htons (sizeof (struct GNUNET_TESTBED_InitMessage) +
- strlen (controller_hostname) + 1);
+ msg->header.size = htons (sizeof (struct GNUNET_TESTBED_InitMessage));
msg->host_id = htonl (GNUNET_TESTBED_host_get_id_ (host));
- msg->event_mask = GNUNET_htonll (controller->event_mask);
- strcpy ((char *) &msg[1], controller_hostname);
- GNUNET_TESTBED_queue_message_ (controller,
- (struct GNUNET_MessageHeader *) msg);
- return controller;
+ msg->event_mask = GNUNET_htonll (c->event_mask);
+ GNUNET_TESTBED_queue_message_ (c, &msg->header);
+ return c;
}
Modified: gnunet/src/testbed/testbed_api_hosts.c
===================================================================
--- gnunet/src/testbed/testbed_api_hosts.c 2013-05-13 12:55:20 UTC (rev
27103)
+++ gnunet/src/testbed/testbed_api_hosts.c 2013-05-13 14:03:32 UTC (rev
27104)
@@ -556,6 +556,7 @@
in_addr = (const struct sockaddr_in *) res->ai_addr;
hostip = inet_ntoa (in_addr->sin_addr);
GNUNET_assert (NULL != hostip);
+ freeaddrinfo (res);
LOG_DEBUG ("Resolved [%s] to [%s]\n", host, hostip);
return hostip;
}
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [GNUnet-SVN] r27104 - gnunet/src/testbed,
gnunet <=