gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GNUnet-SVN] [libmicrohttpd] GNU libmicrohttpd branch master updated. f4


From: gitolite
Subject: [GNUnet-SVN] [libmicrohttpd] GNU libmicrohttpd branch master updated. f4a6e110acd20459f359854c05ba6b43e7cb8dad
Date: Thu, 24 Nov 2016 13:10:55 +0100 (CET)

The branch, master has been updated
       via  f4a6e110acd20459f359854c05ba6b43e7cb8dad (commit)
      from  3a7f7a97ebb9894c31edb7c7f635784256fead73 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f4a6e110acd20459f359854c05ba6b43e7cb8dad
Author: Evgeny Grin (Karlson2k) <address@hidden>
Date:   Thu Nov 24 15:09:55 2016 +0300

    resume_suspended_connections(): Removed FIXME from code.

-----------------------------------------------------------------------

Summary of changes:
 src/microhttpd/daemon.c | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)

diff --git a/src/microhttpd/daemon.c b/src/microhttpd/daemon.c
index 9300a43..91e281e 100644
--- a/src/microhttpd/daemon.c
+++ b/src/microhttpd/daemon.c
@@ -2463,19 +2463,10 @@ resume_suspended_connections (struct MHD_Daemon *daemon)
 
   if (daemon->resuming)
     next = daemon->suspended_connections_head;
-  /* Clear the flag *only* if connections will be resumed otherwise
-     it may accidentally clear flag that was set at the same time in
-     another thread (just after 'if (MHD_NO != daemon->resuming)' in
-     this thread).
-
-     FIXME: is this not prevented by the lock!?
-
-     Clear flag *before* resuming connections otherwise new connection can
-     be set to "resuming" in other thread, but missed resuming in this
-     function at this time so clearing flag at end will clear it without
-     actually resuming of new connection. */
-  if (NULL != next)
-    daemon->resuming = false;
+
+  EXTRA_CHECK(NULL != next);
+  daemon->resuming = false;
+
   while (NULL != (pos = next))
     {
 #ifdef UPGRADE_SUPPORT


hooks/post-receive
-- 
GNU libmicrohttpd



reply via email to

[Prev in Thread] Current Thread [Next in Thread]