This patch builds upon a previous non-behavior-changing patch which I
wrote and Alexander Malmberg comitted this morning on my behalf. For
some background:
NSWorkspace had a private convenience class called _getImageWithName:
which, with the permission of Alexander Malmberg, we moved to NSImage
and renamed to -standardImageWithName: and modified slightly so the
alternate: argument was not necessary (it now intelligently looks for
"ImageName" and then for "common_ImageName" (and anything else for that
matter, like "camaelon_ImageName", if you override the method.) In any
event, What this patch does is enable icon themability. You can have
sets of icons which you can use by simply having a very small bundle
override the -getImageWithName: method.
This patch builds upon the previous one, by making nearly every single
image which was previously loaded directly via NSImage -imageNamed:
"common_ImageName" load with the new convenience NSImage method.
Unless you want your own icon set, you will notice zero behavioral change.
Everyone, please comment on this...If I don't hear anything negative
from anyone by tuesday or so of next week, I will commit it as-is. It
works on my machine.