Re: [Gnustep-cvs] r24007 - in /libs/gui/trunk: ChangeLog Source/GSDragView.m Source/NSCell.m Source/NSTableView.m

[Fred Kiefer]

matt rice schrieb:
> Author: ratmice
> Date: Wed Nov  1 10:50:00 2006
> New Revision: 24007
> 
> URL: http://svn.gna.org/viewcvs/gnustep?rev=24007&view=rev
> Log:
>         * Source/NSTableView.m: Add new private methods.
>         (-mouseDown:): Reorganize and don't track cells until dragging
>         has been ruled out.
>         * Source/NSCell.m (trackMouse:inRect:ofView:untilMouseUp:):
>         Handle events no longer in the queue.
>         * Source/GSDragView.m: Change NSLog to NSDebugLLog.
> 

Hi Matt,

first of all, thank you for doing all this great work in cleaning up the
behaviour of NSTableView. This is a very complex class and it is so
unbelievable hard to get things right there.
A few comments to this specific change.

- It looks like you are not using the standard GNUstep formatting rules.
I must admit that I am not following them all the time, but the way you
place your blanks or rather leave them out, should be adopted to the to
be more readable. One space character after a colon should be used :-)

- The new method _startDragOperationWithEvent: should pass on the offset
for the dragging and not mix this with the start position.

- In the new tracking method, we only check if the column is editable,
shouldn't we use the method that checks for the cell to be editable?
(BTW in this the comments are still wrong)

- A bit more comments in the mouseDown: method would be helpful. This is
so complex and there are so many different things we tried before, that
we really need to explain what is happening and why. I still don't
understand if the dragging is stealing events from the tracking or the
other way around or even both may happen.

You see, this are less things that are wrong, but rather stuff that
needs to be clearer to guarantee that the progress you are making here
will last.

Cheers
Fred