[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Working NSSearchFieldCell archiving support
From: |
Fred Kiefer |
Subject: |
Re: [PATCH] Working NSSearchFieldCell archiving support |
Date: |
Mon, 07 Sep 2009 18:43:39 +0200 |
User-agent: |
Thunderbird 2.0.0.22 (X11/20090605) |
Quentin Mathé schrieb:
> Le 7 sept. 2009 à 16:10, Fred Kiefer a écrit :
>
>> I committed a slightly different patch, to keep the size of the class
>> the same. Please check that I didn't break anything.
>
> I just tested it. Both keyed and non-keyed archiving works fine. Thanks :-)
>
> The only thing I'm not convinced is the change of the NSMenuItem type to
> id <NSMenuItem> if it's only a purpose is to eliminate the
> NSValidatedUserInterfaceItem related warning.
> The change is fine if GNUstep is going to continue to support NSMenuItem
> protocol though.
>
> I'd like to suggest to make NSMenuItem protocol conforms to
> NSValidatedUserInterfaceItemProtocol as Apple did:
> http://developer.apple.com/legacy/mac/library/documentation/Cocoa/Reference/ApplicationKit/Protocols/NSMenuItem_Protocol/Reference/Reference.html
>
>
> The change is really simple:
> @protocol NSMenuItem <NSValidatedUserInterfaceItem, NSCopying, NSCoding,
> NSObject>
>
> This would eliminate warnings in many GNUstep applications (e.g. Gorm)
> which use the NSMenuItem class type.
Thank you, done.
Fred