[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
some NSInteger to NSUinterger changes in -base
From: |
Sebastian Reitenbach |
Subject: |
some NSInteger to NSUinterger changes in -base |
Date: |
Mon, 09 Apr 2012 17:58:20 +0200 |
User-agent: |
SOGoMail 1.3.14 |
Hi,
while looking at latest release compilation warnings on OpenBSD amd64, I found
that some of the changes made after the release don't seem to be right. NSArray
count or indexOfObject return NSUInteger and also NSRange.location is
NSUInteger, but the variables were changed from int to NSInteger. I think they
should be NSUInteger.
is it OK when I commit the patch below?
Sebastian
Index: Tools/make_strings/StringsFile.m
===================================================================
--- Tools/make_strings/StringsFile.m (revision 34987)
+++ Tools/make_strings/StringsFile.m (working copy)
@@ -127,7 +127,7 @@
NSMutableArray *update_list=[[NSMutableArray alloc] init];
NSArray *lines;
NSString *l;
- NSInteger i,c,pos;
+ NSUInteger i,c,pos;
NSMutableDictionary *dummy_entries=[[NSMutableDictionary alloc] init];
NSMutableString *user_comment=[[NSMutableString alloc] init];
Index: Tools/pl.m
===================================================================
--- Tools/pl.m (revision 34987)
+++ Tools/pl.m (working copy)
@@ -39,7 +39,7 @@
NSFileHandle *fileHandle = nil;
NSProcessInfo *processInfo = [NSProcessInfo processInfo];
NSArray *arguments = [processInfo arguments];
- NSInteger outputIndex = 0;
+ NSUInteger outputIndex = 0;
// insert your code here
outputIndex = [arguments indexOfObject: @"-output"];
@@ -94,7 +94,7 @@
NSFileHandle *fileHandle = nil;
NSProcessInfo *processInfo = [NSProcessInfo processInfo];
NSArray *arguments = [processInfo arguments];
- NSInteger inputIndex = 0;
+ NSUInteger inputIndex = 0;
// insert your code here
inputIndex = [arguments indexOfObject: @"-input"];
- some NSInteger to NSUinterger changes in -base,
Sebastian Reitenbach <=