[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: DBusKit build failure
From: |
Philippe Roussel |
Subject: |
Re: DBusKit build failure |
Date: |
Sat, 21 Apr 2012 14:12:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Le 21/04/2012 13:58, Niels Grewe a écrit :
> On Sat, Apr 21, 2012 at 01:45:45PM +0200, Philippe Roussel wrote:
>> I'm not the one who added -Werror to the default build of DBusKit and I
>> don't want to argue about standards or compiler. In my point of vue it
>> quite simple : if it's in the source repository it should compile with a
>> supported compiler (and I'm not arguing about 2.95.3 support here so
>> please), end of story.
>
> True. But please note the folllowing: -Werror is not at fault here,
> -Wdeclaration-after-statement is. Also, -Werror is only used for code in
> trunk as a basic code quality check, release versions disable it since
> releases are supposed not to have known problems.
Well, -Wdeclaration-after-statement is what causes the warning and is
questionable but -Werror is what turns the warning into a build error.
Anyway, thanks for applying the patch.
Philippe