[SCM] GNU gnutls branch, master, updated. gnutls_3_1_5-5-ga2c16b9

[Nikos Mavrogiannopoulos]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU gnutls".

http://git.savannah.gnu.org/cgit/gnutls.git/commit/?id=a2c16b9539c9dc6b0aa58b8bcc526b4293e670f6

The branch, master has been updated
       via  a2c16b9539c9dc6b0aa58b8bcc526b4293e670f6 (commit)
       via  336f779b5129dc1536da639d32c49d6bfe21e757 (commit)
      from  55ff4cdd66d1761d18b2b7e2cb268eac5a355961 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a2c16b9539c9dc6b0aa58b8bcc526b4293e670f6
Author: Nikos Mavrogiannopoulos <address@hidden>
Date:   Sun Nov 25 12:22:22 2012 +0100

    updated todo list

commit 336f779b5129dc1536da639d32c49d6bfe21e757
Author: Nikos Mavrogiannopoulos <address@hidden>
Date:   Sun Nov 25 12:04:06 2012 +0100

    Allow for bit strings that are not a multiple of 8.

-----------------------------------------------------------------------

Summary of changes:
 doc/TODO          |   10 +++-------
 lib/x509/common.c |   13 ++++++++++---
 2 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/doc/TODO b/doc/TODO
index 13764a8..0eaa06c 100644
--- a/doc/TODO
+++ b/doc/TODO
@@ -13,8 +13,6 @@ Current list:
 - Add DTLS 1.2 support (RFC6347)
 - Add certificate image support (see RFC3709, RFC6170)
 - RFC 3280 compliant certificate path validation.
-  - Check path length constraints.
-  - Check keyCertSign key usages.
   - Reject extensions in v1 certificates.
 - Certificate chain validation improvements:
   - Implement "correct" DN comparison (instead of memcmp).
@@ -22,8 +20,7 @@ Current list:
   - Support path length constraints.
 - Perform signature calculation in PKCS #11 using not plain
   RSA but rather the combination of RSA-SHA256, RSA-SHA1 etc.
-  That will allow the usage of more secure tokens that do not
-  allow plain RSA.
+  That will allow the usage of tokens that do not allow plain RSA.
 - Support PKCS#8 DES-MD5 (tests/enc3pkcs8.pem) encrypted keys.
   (openssl seems to use DES-MD5 to encrypt keys by default)
 - Add support for generating empty CRLs
@@ -40,9 +37,8 @@ Current list:
    firstElement, bit_mask, ...) for platforms that libtool's
    -export-symbols-regex doesn't work.
 - Add Kerberos ciphersuites
-- Exhaustive test suite, using NIST's PKI Test vectors,
-  see http://csrc.nist.gov/pki/testing/x509paths_old.html
-  and http://csrc.nist.gov/pki/testing/x509paths.html
+- Update the current test suite, using the newest NIST's PKI Test vectors,
+  see http://csrc.nist.gov/pki/testing/x509paths.html
 - Make gnutls-cli-debug exit with better error messages if the
   handshake fails, rather than saying that the server doesn't support
   TLS.
diff --git a/lib/x509/common.c b/lib/x509/common.c
index b89c9a7..b97fc06 100644
--- a/lib/x509/common.c
+++ b/lib/x509/common.c
@@ -958,7 +958,10 @@ _gnutls_x509_read_value (ASN1_TYPE c, const char *root,
     }
   
   if (etype == ASN1_ETYPE_BIT_STRING)
-    len /= 8;
+    {
+      len /= 8;
+      len++;
+    }
 
   tmp = gnutls_malloc ((size_t)len+1);
   if (tmp == NULL)
@@ -977,10 +980,14 @@ _gnutls_x509_read_value (ASN1_TYPE c, const char *root,
     }
 
   if (etype == ASN1_ETYPE_BIT_STRING)
-    len /= 8;
+    {
+      ret->size = len / 8;
+      if (len % 8 > 0)
+        ret->size++;
+    }
+  else ret->size = (unsigned)len;
 
   ret->data = tmp;
-  ret->size = (unsigned)len;
 
   return 0;
 


hooks/post-receive
-- 
GNU gnutls